Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 21 Jan 2023 22:21:25 +0100
From:      Matthias Andree <mandree@FreeBSD.org>
To:        Baptiste Daroussin <bapt@FreeBSD.org>, Jesper Schmitz Mouridsen <jsm@FreeBSD.org>
Cc:        ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Subject:   Re: git: 4e77dee79c17 - main - www/librewolf: New port
Message-ID:  <c48e70ee-75a6-5ee8-2d86-e0029b0e14f5@FreeBSD.org>
In-Reply-To: <20230121211214.ldsnnr2q2762d75a@aniel.nours.eu>
References:  <202301211835.30LIZGqT095965@gitrepo.freebsd.org> <20230121211214.ldsnnr2q2762d75a@aniel.nours.eu>

next in thread | previous in thread | raw e-mail | index | archive | help
Am 21.01.23 um 22:12 schrieb Baptiste Daroussin:
> On Sat, Jan 21, 2023 at 06:35:16PM +0000, Jesper Schmitz Mouridsen wrote:
>> The branch main has been updated by jsm:
>>
>> URL: https://cgit.FreeBSD.org/ports/commit/?id=4e77dee79c17245e0c3b4b98af5a718ed2c5eb81
>>
>> commit 4e77dee79c17245e0c3b4b98af5a718ed2c5eb81
>> Author:     Martin Filla <freebsd@sysctl.cz>
>> AuthorDate: 2023-01-19 18:52:57 +0000
>> Commit:     Jesper Schmitz Mouridsen <jsm@FreeBSD.org>
>> CommitDate: 2023-01-21 18:34:48 +0000
>>
>>      www/librewolf: New port
>>      
>>      PR:     258503
> 
> pkg-descr has a WWW: line which it should not have.

Baptiste: An artifact of us having too little manpower to deal with 
things in due time. If you check the PR you will see it was initially 
submitted 2021-09-14, long before we had moved WWW into Makefiles.

I suppose someone might want to do a script to search on Bugzilla items 
and comment on all open bugs that aim to add a WWW: to pkg-descr.

Jesper: while we're talking about what future commits could do better:
On my wishlist for new ports' initial commits: please include a copy of 
pkg-descr in the initial commit of a new port.  Maybe I am old skool 
though ;-)

Jesper, could you move the WWW: into the Makefile, or do you need a hand?

ports/CHANGES:
...
> 20220907:
> AUTHOR: se@FreeBSD.org
> 
>   The convention of a WWW: line at the end of each port's pkg-descr file
>   has been changed to a WWW= definition in the port's Makefile. All ports
>   have been converted to follow this new scheme.
 > [...]
...

-- 
Matthias Andree
FreeBSD ports committer




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c48e70ee-75a6-5ee8-2d86-e0029b0e14f5>