Date: Mon, 22 Jan 2018 13:38:47 +0000 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: Emmanuel Vadot <manu@bidouilliste.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328257 - in head/sys: arm/broadcom/bcm2835 dts/arm modules Message-ID: <88070.1516628327@critter.freebsd.dk> In-Reply-To: <20180122135905.203e19ce94510854777dff63@bidouilliste.com> References: <201801220710.w0M7AUm9091853@repo.freebsd.org> <20180122135905.203e19ce94510854777dff63@bidouilliste.com>
next in thread | previous in thread | raw e-mail | index | archive | help
-------- In message <20180122135905.203e19ce94510854777dff63@bidouilliste.com>, Emm= anuel Vadot writes: >> +#if 0 >> + // XXX: default state is disabled in RPI3 DTB, assume for now >> + // XXX: that people want the PWM to work if the KLD this module. >> if (!ofw_bus_status_okay(dev)) >> return (ENXIO); >> +#endif > > This is really bad, one need to use overlay to enable the node. > Leaving this I will predict that in the near futur you will have >someone complaining that he set to load the module at boot, unplug is >pwm testing gear and plug another type of HAT and that it makes funny >thing. As long as you don't set any of dev.pwm.0.* sysctls, the bcm283x_pwm driver doesn't do anything, so that situation is harmless. > Can you please revert this part ? Once I find out how to get similar behaviour, ie: kldload without having to reboot to load a DT-overlay. My preference would be that DT-overlays could be compiled into kmods, but I'm fine with any reasonable commahd that can load an overlay without a reboot. Or alternatively, a command which will change the "status=3Ddisable" to "status=3Dokay" in the already loaded DT ? -- = Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe = Never attribute to malice what can adequately be explained by incompetence= .
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?88070.1516628327>