Date: Fri, 8 Jan 1999 13:50:01 -0800 (PST) From: Brian Somers <brian@Awfulhak.org> To: freebsd-bugs@FreeBSD.ORG Subject: Re: bin/9382: BUG report for ppp(8) Message-ID: <199901082150.NAA01634@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/9382; it has been noted by GNATS.
From: Brian Somers <brian@Awfulhak.org>
To: Toshiomi.Moriki@ma1.seikyou.ne.jp
Cc: freebsd-gnats-submit@FreeBSD.ORG
Subject: Re: bin/9382: BUG report for ppp(8)
Date: Fri, 08 Jan 1999 08:29:42 +0000
>
> >Number: 9382
> >Category: bin
> >Synopsis: BUG report for ppp(8)
[.....]
> >Fix:
> This patch will fix the problem.
>
> *** datalink.c.orig Fri Jan 8 10:29:25 1999
> --- datalink.c Fri Jan 8 11:28:10 1999
> ***************
> *** 299,304 ****
> --- 299,305 ----
> datalink_HangupDone(dl);
> break;
> case DATALINK_DIAL:
> + dl->phone.alt = NULL; /* phone attempt succeeded */
> datalink_NewState(dl, DATALINK_LOGIN);
> chat_Init(&dl->chat, dl->physical, dl->cfg.script.login, 0, NULL);
> return datalink_UpdateSet(d, r, w, e, n);
[.....]
You're right, but the assignment should be for the DATALINK_LOGIN
case rather than the DATALINK_DIAL one. When DATALINK_DIAL has
succeeded, there's still time for the _LOGIN to fail.
--
Brian <brian@Awfulhak.org> <brian@FreeBSD.org> <brian@OpenBSD.org>
<http://www.Awfulhak.org>;
Don't _EVER_ lose your sense of humour !
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199901082150.NAA01634>