Date: Mon, 15 Aug 2005 00:54:31 +0200 (CEST) From: Antoine Pelisse <apelisse@gmail.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: kern/84934: [PATCH] Panic in kern_exec.c Message-ID: <200508142254.j7EMsV9R088863@xloling.org> Resent-Message-ID: <200508142300.j7EN0W5v010871@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 84934 >Category: kern >Synopsis: [PATCH] Panic in kern_exec.c >Confidential: no >Severity: critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Aug 14 23:00:32 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Antoine Pelisse >Release: FreeBSD 7.0-CURRENT i386 >Organization: Xloling >Environment: System: FreeBSD gordon.xloling.org 7.0-CURRENT FreeBSD 7.0-CURRENT #0: Sun Aug 14 23:48:35 CEST 2005 i386 >Description: Fix for panic: http://people.freebsd.org/~pho/stress/log/cons151.html >How-To-Repeat: >Fix: --- kern/kern_exec.c.orig Sun Aug 14 22:39:41 2005 +++ kern/kern_exec.c Sun Aug 14 22:43:16 2005 @@ -667,7 +667,14 @@ /* Cache arguments if they fit inside our allowance */ if (ps_arg_cache_limit >= i + sizeof(struct pargs)) { + /* + * the lock needs to be released as begin_argv is + * stored in pageable memory (allocated with + * kmem_alloc_wait) + */ + PROC_UNLOCK(p); bcopy(imgp->args->begin_argv, newargs->ar_args, i); + PROC_LOCK(p); p->p_args = newargs; newargs = NULL; } Feel free to modify the comment, Regards. >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200508142254.j7EMsV9R088863>