Date: Mon, 9 Nov 2020 11:47:49 -0800 From: Eric Joyner <erj@freebsd.org> To: Ryan Stone <rysto32@gmail.com> Cc: freebsd-net <freebsd-net@freebsd.org>, Piotr.Pietruszewski@intel.com Subject: Re: iflib tx watchdog doesn't appear that it can work anymore Message-ID: <CA%2Bb0zg9R2N6C6vzi5oC=VDZvX92FoYOZBKx=8b_B2W9G1uZwyQ@mail.gmail.com> In-Reply-To: <CAFMmRNw%2B-1Hn4HyKqXsAMxx40aUPPOVubppAivUieBdedMSF1Q@mail.gmail.com> References: <CAFMmRNw%2B-1Hn4HyKqXsAMxx40aUPPOVubppAivUieBdedMSF1Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
I'll add Piotr, the author of your linked patch, to this thread. Are you seeing a problem connected to the watchdog? Piotr tells me that IFLIB_QUEUE_WORKING isn't used now, but it wasn't even used before his patch. - Eric On Wed, Nov 4, 2020 at 8:47 AM Ryan Stone <rysto32@gmail.com> wrote: > https://svnweb.freebsd.org/base?view=revision&revision=356310 > > As of r356310, there does not appear to be a way that ift_qstatus can > be set to anything but IFLIB_QUEUE_IDLE. As a result, I don't see > that there is any way for the watchdog to ever fire. > > I think that iflib has missed setting ift_qstatus to > IFLIB_QUEUE_WORKING when packets are enqueued on the rx ring. > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CA%2Bb0zg9R2N6C6vzi5oC=VDZvX92FoYOZBKx=8b_B2W9G1uZwyQ>