Date: Mon, 21 Sep 2015 17:59:48 -0600 From: Warner Losh <imp@bsdimp.com> To: Rui Paulo <rpaulo@me.com> Cc: Adrian Chadd <adrian.chadd@gmail.com>, jhb@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r287934 - head/sys/boot/efi/loader Message-ID: <5427AC7C-1B0B-4273-B758-DB0C1BDF656F@bsdimp.com> In-Reply-To: <35a0f1b6-0236-4b0e-b919-00cab07429be@me.com> References: <35a0f1b6-0236-4b0e-b919-00cab07429be@me.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] Apart from the inlining issue John raised (which I agree with his solution on, btw) and the one cam ctl module, what other modules are meaningfully different when compiled as modules. Assume that the auto-loading bit is solved, at least for devices on self-enumerating busses. Warner > On Sep 21, 2015, at 4:53 PM, Rui Paulo <rpaulo@me.com> wrote: > > No, that doesn't work very well. Not only the modules don't auto-load, the way the modules are compiled is different. See, for example, cam ctl which doesn't compile the sg code when it's built into the kernel, but compiles it when it's built as a module. The sg code is currently buggy and causes insta-panics with GNOME 3 (perhaps the auto-mounter in hald (?)). > -- > Rui Paulo > > > On Sep 21, 2015, at 11:24 AM, Adrian Chadd <adrian.chadd@gmail.com> wrote: > >> Hi, >> >> Warner has been working on the modular kernel thing. But honestly, I >> think we should just start biting that bullet and ship a modules-only >> GENERIC by default.. >> >> >> -a >> >> >> On 21 September 2015 at 11:02, Rui Paulo <rpaulo@me.com> wrote: >>> So, we're going to keep ignoring the problem and keep patching things up? >>> It's a bit sad that a single driver (pmspcv) is able to cause so much >>> problems. >>> >>> -- >>> Rui Paulo >>> >>> >>> On Sep 17, 2015, at 01:36 PM, John Baldwin <jhb@FreeBSD.org> wrote: >>> >>> Author: jhb >>> Date: Thu Sep 17 20:36:46 2015 >>> New Revision: 287934 >>> URL: https://svnweb.freebsd.org/changeset/base/287934 >>> >>> >>> Log: >>> The EFI boot loader allocates a single chunk of contiguous memory to >>> hold the kernel, modules, and any other loaded data. This memory block >>> is relocated to the kernel's expected location during the transfer of >>> control from the loader to the kernel. >>> >>> The GENERIC kernel on amd64 has recently grown such that a kernel + zfs.ko >>> no longer fits in the default staging size. Bump the default size from >>> 32MB to 48MB to provide more breathing room. >>> >>> PR: 201679 >>> Reviewed by: imp >>> MFC after: 1 week >>> Differential Revision: https://reviews.freebsd.org/D3666 >>> >>> >>> Modified: >>> head/sys/boot/efi/loader/copy.c >>> >>> Modified: head/sys/boot/efi/loader/copy.c >>> ============================================================================== >>> --- head/sys/boot/efi/loader/copy.c Thu Sep 17 20:36:34 2015 >>> (r287933) >>> +++ head/sys/boot/efi/loader/copy.c Thu Sep 17 20:36:46 2015 >>> (r287934) >>> @@ -38,7 +38,7 @@ __FBSDID("$FreeBSD$"); >>> #include <efilib.h> >>> >>> #ifndef EFI_STAGING_SIZE >>> -#define EFI_STAGING_SIZE 32 >>> +#define EFI_STAGING_SIZE 48 >>> #endif >>> >>> #define STAGE_PAGES ((EFI_STAGING_SIZE) * 1024 * 1024 / 4096) >>> [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJWAJn0AAoJEGwc0Sh9sBEANREP/iu9rtcXKEXWoA/cjk7SKUFs CZcKGlqWU62fIGR/EcZ4jiXQjUHkC7XW/I+91jZr/DXQMCWYhJ5HKza2gmb53yKG QS8lZsqt0bACMKrRS3QP9G0SpR+oGFVIx7eCUHBeTGbHzxCbuAqYN+fPV45843TH e7mo/Om6aOrrXg6lLueWttuqN4l+I11BBALULXytEnypMXgF/eVbBl5MMHVTgd+J 9sMLFMnZmLjZ+pzS1mPf7oJPWK+OjlMrzc1tKKc+itg9ZsP1BNhZR0OPNp1CkAiL cV4JwlrnIBb2aFBTyzGL2KelcxcG8XqSGbVWeQqVL6iXmh/O3c0zh9CI+fkgWCJz iDykOc7Z/SWrPG7N3V13JP7ICgO8qXvtZO58Li69zTm0CfdDX/i9d7qTDWax2oHm 5NrhIpxRg18s8DSCWJh/dVuC3P8IAW0Poa3twkoHZTxh2p3VXxQJpgPNPp8t6fLY qaNTPNfPsAuC3cVZTCnoQcYM1gK5gKYkJ2o/ImF4R/QylH2AD0LxAZbcUDaLFxlw jiljctlhtpW1s9JsbT704K0RrNI8W22PVni0NnfCmeGfT/6T2ZHQHV3yotTzcvCq mZ9xDwmX21Y5pNGG8xI08i9aAosH/NLUFg1YoI7m8pfRGYfUq27FbEiRrko5fKk4 7hpVjXKKXMqDDZ7LhHGS =DoMH -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5427AC7C-1B0B-4273-B758-DB0C1BDF656F>