Date: Tue, 5 Jul 2016 16:02:46 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Bruce Evans <brde@optusnet.com.au> Cc: Konstantin Belousov <kib@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r302328 - in head/sys: kern sys Message-ID: <BA5F31E6-8E9F-4657-8858-773267623870@gmail.com> In-Reply-To: <20160705200552.Y1821@besplex.bde.org> References: <201607031819.u63IJm79075708@repo.freebsd.org> <20160705200552.Y1821@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_78F091A8-40F8-49B6-BA14-68BBF36D0336 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Jul 5, 2016, at 03:08, Bruce Evans <brde@optusnet.com.au> wrote: >=20 > On Sun, 3 Jul 2016, Konstantin Belousov wrote: >=20 > This is mostly a test reply (replying to src-committers has stopped > working for newer commits). >=20 >> Log: >> Provide helper macros to detect 'non-silent SBDRY' state and to >> calculate appropriate return value for stops. Simplify the code by >> using them. >>=20 >> Fix typo in sig_suspend_threads(). The thread which sleep must be >> aborted is td2. (*) >>=20 >> In issignal(), when handling stopping signal for thread in >> TD_SBDRY_INTR state, do not stop, this is wrong and fires assert. >> This is yet another place where execution should be forced out of >> SBDRY-protected region. For such case, return -1 from issignal() and >> translate it to corresponding error code in sleepq_catch_signals(). >> Assert that other consumers of cursig() are not affected by the new >> return value. (*) >>=20 >> Micro-optimize, mostly VFS and VOP methods, by avoiding calling the >> functions when SIGDEFERSTOP_NOP non-change is requested. (**) >>=20 >> Reported and tested by: pho (*) >> Requested by: bde (**) >> Sponsored by: The FreeBSD Foundation >> MFC after: 2 weeks >> Approved by: re (gjb) >=20 > Thanks, but this is still very slow (even slower than beore the > micro-optimization). Could you please bump __FreeBSD_version ? This change broke = emulators/open-vm-tools from pkg.FreeBSD.org , so it needs to be = rebuilt. Thanks, -Ngie $ sudo service vmware-kmod start Loading vmmemctl kernel module: already loaded. Loading vmxnet kernel module: already loaded. Loading vmblock kernel module: failed. Cannot 'start' vmware_guest_vmhgfs. Set vmware_guest_vmhgfs_enable to = YES in /etc/rc.conf or use 'onestart' instead of 'start'. $ tail -n 3 /var/log/messages Jul 5 15:59:03 fbsd11 fetch: gethostby*.getanswer: asked for = "mirror.easthsia.com IN AAAA", got type "A" Jul 5 16:01:43 fbsd11 kernel: link_elf_obj: symbol sigdeferstop = undefined Jul 5 16:01:43 fbsd11 kernel: linker_load_file: Unsupported file type --Apple-Mail=_78F091A8-40F8-49B6-BA14-68BBF36D0336 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJXfDyWAAoJEPWDqSZpMIYVDG8P/3R8XdRh5swGYWQVDCHykNwB E8yFBoUedMSkSoyHoLW4Zjcn+goFDFctgQGewQlTxGoqBPFv/5QpnjHALmc9dF3s NG6QWaEVpNoVW1ZKBVLHdcRlvzTTHrkWKdokqQQYez/2oKQ7Svs3C2VqToMrkTly 7Gdg6EUol68Zoha/EI3EP7t0590IrxkPi0tZFxcfqCbbZNPAZG36r/23oCQqubLA pSisv6JcXqLUbBgiUd6IcVNXp9q7aZ2HZEDCmm/Be8DVTUUo6KTc0FJOas8M6usY EeBRv8/RZiZNYbIOudWHw2mJfPVA4X9t50c0xQgn5OhTAsZEpXZ4ztsAhfjYcZp8 XBwPmpThC9gSvgWiOjkgi9GxKL37qwwbFpbXx7sIavsafqLaU1Kj5k/CVyLugatT +4jekgpiOiPlJyBARCN7YRU3XJQHsRNu+nLteDp5bUDnCLHhmRALPTksuLvGmDsV RwLluI8a2keq8R8L1JsLw4y8W6aOwufMQCB9HDRb/hEUHcEDFggCdBbJ9LkNveYK buDO4PZIwjkPIj8g1iFnL65wNfh/iZMV5zxiBKmo/wKFZ0+gDVg2uG5n66dYEA3J R8l0CJ342Wqw8a8cABWwb3/utUcnsn9NG5fvprpK18ajmRNUmZwc2K6BW5r6aiy9 FRgiLe9gJTWb4AIlkFqx =jVft -----END PGP SIGNATURE----- --Apple-Mail=_78F091A8-40F8-49B6-BA14-68BBF36D0336--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BA5F31E6-8E9F-4657-8858-773267623870>