Date: Wed, 04 Apr 2018 00:28:53 +0200 From: Emmanuel Vadot <manu@bidouilliste.com> To: Marcin Wojtas <mw@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, owner-src-committers@freebsd.org Subject: Re: svn commit: r331961 - in head/sys: arm/mv dts/arm Message-ID: <5dea78be118fa5ee4b8cb77a1e26a6f0@megadrive.org> In-Reply-To: <201804032221.w33MLDTE019502@repo.freebsd.org> References: <201804032221.w33MLDTE019502@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2018-04-04 00:21, Marcin Wojtas wrote: > Author: mw > Date: Tue Apr 3 22:21:12 2018 > New Revision: 331961 > URL: https://svnweb.freebsd.org/changeset/base/331961 > > Log: > Make Marvell AmadaXP timer driver more generic > > Store pointers to SoC specific functions in mv_timer_config structure > and determine proper config in runtime based on compatible string > from FDT. > Compatible string for ArmadaXP timers is changed to match Linux FDT. > Armada 38x uses generic Cortex-A9 timer and separate watchdog > drivers, so > it does not need to be supported by timer driver. > > Submitted by: Rafal Kozik <rk@semihalf.com> > Reviewed by: manu > Obtained from: Semihalf > Sponsored by: Stormshield > Differential Revision: https://reviews.freebsd.org/D14741 Hello Marcin, I've only reviewed the DTS part. Also you didn't address andrew@ comment, see https://reviews.freebsd.org/D14741?id=40452#inline-89719 Cheers, -- Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5dea78be118fa5ee4b8cb77a1e26a6f0>