Date: Mon, 22 Nov 2010 11:06:20 +0200 From: Andriy Gapon <avg@freebsd.org> To: Paul B Mahol <onemda@gmail.com> Cc: hackers@freebsd.org Subject: Re: Remove printf in acpi_tz_sanity() Message-ID: <4CEA328C.2060508@freebsd.org> In-Reply-To: <AANLkTimJuq57mzAyb%2BaZ8imrW0cc4qNbZ0FL4_i=3ub9@mail.gmail.com> References: <AANLkTimThbVyXmgU76m44GTzR0qGAQuJt-9xwunP-QdQ@mail.gmail.com> <4CE98C7E.90301@freebsd.org> <AANLkTimJuq57mzAyb%2BaZ8imrW0cc4qNbZ0FL4_i=3ub9@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
on 22/11/2010 01:18 Paul B Mahol said the following: > On Sun, Nov 21, 2010 at 9:17 PM, Andriy Gapon <avg@freebsd.org> wrote: >> As is - this is a perfect candidate for a "local only" patch. >> To be included into the tree - this, most probably, has to be controlled by a >> tunable/sysctl. > > So solution for useless console spamming is to add useless sysctl. Are you absolutely sure that they both are/would be useless? For all uses of acpi_tz_sanity()? E.g. if some system has never produced those messages in years and then suddenly starts spewing them out, would that be useless information? > For -1 values, sane default values should be picked up. For current temperature too? > Anyway only _CRT is showing on console, and _PSV & _HOT are both -1 for tz0. On your system. > I'm not first one mentioning this and issue is old several years. OK. -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4CEA328C.2060508>