Date: Tue, 14 Mar 2023 07:54:48 +0000 From: Jessica Clarke <jrtc27@freebsd.org> To: Emmanuel Vadot <manu@bidouilliste.com> Cc: Wei Hu <weh@microsoft.com>, "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org> Subject: Re: git: 15e7fa83ef3c - main - arm64: Hyper-V: Add vPCI and Mellanox driver modules into build Message-ID: <49D67579-28BC-4734-BDF7-BC8669FFF20C@freebsd.org> In-Reply-To: <20230314084603.de49c42bc92ad1b20d38b372@bidouilliste.com> References: <202303130300.32D30Q0K068420@gitrepo.freebsd.org> <CE8CFD56-76F2-4FE6-8774-05938B476DAD@freebsd.org> <4F72E2FD-6E84-40F1-981D-A18C8DE22FDD@freebsd.org> <SI2P153MB0441AFEBFA48BE3327BE26D6BBBE9@SI2P153MB0441.APCP153.PROD.OUTLOOK.COM> <3D6476D5-807E-4D9A-87BC-F5916FBEBE5B@freebsd.org> <SI2P153MB0441C64F39CE0519F6F06D8ABBBE9@SI2P153MB0441.APCP153.PROD.OUTLOOK.COM> <E9FC8A98-52B0-4311-8A45-65B614DBA783@freebsd.org> <20230314084603.de49c42bc92ad1b20d38b372@bidouilliste.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 14 Mar 2023, at 07:46, Emmanuel Vadot <manu@bidouilliste.com> wrote: >=20 > On Tue, 14 Mar 2023 06:59:00 +0000 > Jessica Clarke <jrtc27@freebsd.org> wrote: >=20 >> On 14 Mar 2023, at 06:56, Wei Hu <weh@microsoft.com> wrote: >>>=20 >>>>>>>> + >>>>>>>> +options COMPAT_LINUXKPI >>>>>>>> +device xz >>>>>>>> + >>>>>>>> +device mlx5 >>>>>>>> +device mlxfw >>>>>>>> +device mlx5en >>>>>>>> +options RATELIMIT >>>>=20 >>>> As pointed out on IRC, no other kernel config, aside from LINT = ones, enables >>>> this. Therefore this seems pretty dubious to add; why does >>>> arm64 need it whilst amd64, which does include Mellanox drivers in = its >>>> GENERIC, doesn't need it? >>>>=20 >>>=20 >>> How about moving these to std.nvidia? Does it look better to you? >>=20 >> They?re not part of an Nvidia SoC. >>=20 >> Anyway, I already moved them to a new std.azure. >>=20 >> Jess >>=20 >=20 > Why do we need them in GENERIC anyway ? > We have modules already built, we have devmatch, if mlx driver don't > autoload we should just fix that. I guess for the same reasons as https://reviews.freebsd.org/D28469? Jess > --=20 > Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?49D67579-28BC-4734-BDF7-BC8669FFF20C>