Date: Thu, 18 Dec 2003 02:10:19 -0800 (PST) From: Gleb Smirnoff <glebius@cell.sick.ru> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/47920: if ng_pppoe switches to nonstandard mode it stays in it forever Message-ID: <200312181010.hBIAAJ6m044676@freefall.freebsd.org>
index | next in thread | raw e-mail
The following reply was made to PR kern/47920; it has been noted by GNATS. From: Gleb Smirnoff <glebius@cell.sick.ru> To: Yar Tikhiy <yar@FreeBSD.ORG> Cc: FreeBSD-gnats-submit@FreeBSD.ORG Subject: Re: kern/47920: if ng_pppoe switches to nonstandard mode it stays in it forever Date: Thu, 18 Dec 2003 13:08:48 +0300 On Wed, Dec 17, 2003 at 08:42:34PM +0300, Yar Tikhiy wrote: Y> Would you mind testing the below version of your patch, revised. Y> Please pay attention to its points: Y> a) sanity check values passed through sysctl; Y> b) avoid double setting nonstandard mode; Y> c) format source according to style(9); Y> d) initialize pppoe_mode for clarity since it's no longer Y> just a boolean trigger. I have tested it on STABLE. It works OK. I have also asked PR's originator to test it. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPEhelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200312181010.hBIAAJ6m044676>