Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 05 Dec 2000 16:03:38 -0800
From:      Peter Wemm <peter@netplex.com.au>
To:        obrien@FreeBSD.org
Cc:        John Baldwin <jhb@FreeBSD.org>, cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Alfred Perlstein <alfred@FreeBSD.org>
Subject:   Re: cvs commit: src/sys/vm phys_pager.c 
Message-ID:  <200012060003.eB603cJ26865@mobile.wemm.org>
In-Reply-To: <20001205153707.C55259@dragon.nuxi.com> 

next in thread | previous in thread | raw e-mail | index | archive | help
"David O'Brien" wrote:
> On Tue, Dec 05, 2000 at 03:22:15PM -0800, John Baldwin wrote:
> > An excerpt from the Committer's Guide, Rule 5:
> > 
> > "...unless the -STABLE fix is critical, time sensitive or so obvious as
> > to make further testing unnecessary (spelling fixes to manpages,
> > obvious bug/typo fixes, etc.)"
> > 
> > If you had looked at a) the patch, and b) the thread on -hackers, you
> > would have seen that this is an obvious bug/typo, and for people who
> 
> Take liberties with "obvious bug/typo" will only lead to peril.

This is not a liberty.  It is an obvious fix and a killer bug if left alone.

> > I'll also note the very end of rule 5:
> > "In other words, apply common sense."
> 
> I am.

Well, common sense suggests to me that it is perfectly OK to fix it.

Cheers,
-Peter
--
Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au
"All of this is for nothing if we don't go to the stars" - JMS/B5



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200012060003.eB603cJ26865>