Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 7 Aug 2024 15:43:51 GMT
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: a87a5973132b - releng/13.4 - ktrace: Fix an inverted privilege check
Message-ID:  <202408071543.477Fhpsw039505@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch releng/13.4 has been updated by markj:

URL: https://cgit.FreeBSD.org/src/commit/?id=a87a5973132ba396c870068083395761e794ce47

commit a87a5973132ba396c870068083395761e794ce47
Author:     Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2024-08-07 13:38:54 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2024-08-07 15:43:39 +0000

    ktrace: Fix an inverted privilege check
    
    Approved by:    so
    Approved by:    re (cperciva)
    Security:       FreeBSD-SA-24:06.ktrace
    Security:       CVE-2024-6760
    Fixes:  1762f674ccb5 ("ktrace: pack all ktrace parameters into allocated structure ktr_io_params")
    
    (cherry picked from commit 166b7573b5220aadf8b02a85933c9651b909b309)
    (cherry picked from commit f702110bc4bcc593b38674ec6e4fadf6c4626432)
---
 sys/kern/kern_ktrace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/kern/kern_ktrace.c b/sys/kern/kern_ktrace.c
index 2729d0880b31..cc51dbae46f7 100644
--- a/sys/kern/kern_ktrace.c
+++ b/sys/kern/kern_ktrace.c
@@ -585,7 +585,7 @@ ktrprocexec(struct proc *p)
 	PROC_LOCK_ASSERT(p, MA_OWNED);
 
 	kiop = p->p_ktrioparms;
-	if (kiop == NULL || priv_check_cred(kiop->cr, PRIV_DEBUG_DIFFCRED))
+	if (kiop == NULL || priv_check_cred(kiop->cr, PRIV_DEBUG_DIFFCRED) == 0)
 		return (NULL);
 
 	mtx_lock(&ktrace_mtx);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202408071543.477Fhpsw039505>