Date: Mon, 17 Oct 2022 11:46:36 +0000 From: bugzilla-noreply@freebsd.org To: multimedia@FreeBSD.org Subject: [Bug 267100] graphics/gstreamer1-plugins-gl: fails to build if graphics/libdrm is installed Message-ID: <bug-267100-12827-EotOM6Ftv2@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-267100-12827@https.bugs.freebsd.org/bugzilla/> References: <bug-267100-12827@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D267100 John Hein <jcfyecrayz@liamekaens.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jcfyecrayz@liamekaens.com, | |michal.zielonka.8001@gmail. | |com, riggs@FreeBSD.org --- Comment #2 from John Hein <jcfyecrayz@liamekaens.com> --- This patch was added: % cat /usr/ports/multimedia//gstreamer1-plugins/files/patch-gst-libs_gst_allocato= rs_meson.build --- gst-libs/gst/allocators/meson.build.orig 2022-09-06 20:56:00 UTC +++ gst-libs/gst/allocators/meson.build @@ -1,3 +1,4 @@ +if get_option('allocators').enabled() gst_allocators_headers =3D files([ 'allocators.h', 'allocators-prelude.h', @@ -58,3 +59,4 @@ allocators_dep =3D declare_dependency(link_with: gstallo sources : allocators_gen_sources) meson.override_dependency('gstreamer-allocators-1.0', allocators_dep) +endif So, unless 'allocators' is explicitly enabled, allocators_dep is not define= d.=20=20 It's not clear from the commit or review why that is there (committer, maintainter CC'd for comment). But if you remove that patch, gstreamer1-plugins-gl gets past 'configure' w= hen libdrm is installed. Because the intent of the patch is not documented, I don't know what to test for breakage if the patch is removed. It may be something that fails to bu= ild, or it could cause some run-time problem, or maybe the patch should just not= be there at all and everything works fine without it. An answer from the patch author would be helpful here. By the way, the reason this only shows up when libdrm is installed is from = this meson.build snippet in work/gst-plugins-base-1.20.3/gts-libs/gl/meson.build: if egl_dep.found() and cc.has_header('libdrm/drm_fourcc.h') optional_deps +=3D allocators_dep endif --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-267100-12827-EotOM6Ftv2>