Date: Sat, 15 May 2021 01:29:01 +0000 From: Rick Macklem <rmacklem@uoguelph.ca> To: "Rodney W. Grimes" <freebsd-rwg@gndrsh.dnsmgr.net>, Daniel Ebdrup Jensen <debdrup@FreeBSD.org> Cc: "freebsd-current@FreeBSD.org" <freebsd-current@FreeBSD.org> Subject: Re: RFC: changing the default NFSv4 minor version? Message-ID: <YQXPR0101MB0968734764B0226154153930DD2F9@YQXPR0101MB0968.CANPRD01.PROD.OUTLOOK.COM> In-Reply-To: <202105141317.14EDHZh5081285@gndrsh.dnsmgr.net> References: <20210514082538.wbbrhhkwebvos6qc@nerd-thinkpad.local>, <202105141317.14EDHZh5081285@gndrsh.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Rodney W. Grimes wrote:=0A=
[stuff snipped]=0A=
>Daniel Ebdrup Jensen wrote:=0A=
>> Hi Rick,=0A=
>>=0A=
>> If I understand your plans correctly, you're not going to be makin=
g=0A=
>> it so that minorversion=3DN complains?=0A=
>=0A=
>Ah, I think that if you specify a minorversion and the server=0A=
>does not support that minorversion it SHOULD complain.=0A=
Yes. The mount attempt currently fails with "minor version not supported"=
=0A=
when the minor version is not supported by the server.=0A=
My plan would not change this when "minorversion=3DN" is specified.=0A=
=0A=
> Only=0A=
>if when a minorversion has NOT been specified should it silently=0A=
>use the highest common version.=0A=
Yes, that's my plan.=0A=
=0A=
>>=0A=
>> In that case, I don't quite understand how it can be a POLA=0A=
>> violation, since presumably it'll fall back to NFSv4.0 if that's=
=0A=
>> the only thing that's supported by ntpd on some other system.=0A=
>=0A=
>Ignoring the ntpd typo, I think ricks concern on POLA is that currently=0A=
>in FreeBSD if you do NOT specify any minor version you get v4.0 and=0A=
>only v4.0 even if both sides support v4.2, so with his change things=0A=
>are suddenly going to change, that may astonish some.=0A=
Yes.=0A=
=0A=
>>=0A=
>> At any rate, I'm all for it since I'm already using NFSv4.2. :)=0A=
>=0A=
>I support this change with the caveats that it only occurs if the=0A=
>minorversion is unspecified and this same negotiation logic is=0A=
>applied to both server and client. (Ie, if I spec a minorversion=0A=
>on the server it is no longer free to negotiate any other version,=0A=
>IE if I spec 1 it should *NOT* drop to 0. It may mean minorversion=0A=
>becomes minorversions or highestminor? So that I can make a=0A=
>server that allows minor=3D{0,1} or even {1,2}, ie I in that second=0A=
>case I want it to NOT use a minor=3D0 mount.=0A=
The server end is passive. It either supports the minor version specified=
=0A=
in the RPC by the client and performs the RPC or it replies NFS4ERR_MINOR_V=
ERSION_MISMATCH if it does not support it.=0A=
The FreeBSD server already has sysctls:=0A=
vfs.nfsd.server_min_minorversion4=0A=
vfs.nfsd.server_max_minorversion4=0A=
that allows a sysadmin to limit the minor versions supported.=0A=
=0A=
I think this satisfies your server requirement?=0A=
=0A=
rick=0A=
=0A=
> Yours,=0A=
> Daniel Ebdrup Jensen=0A=
--=0A=
Rod Grimes rgrimes@freebsd.=
org=0A=
_______________________________________________=0A=
freebsd-current@freebsd.org mailing list=0A=
https://lists.freebsd.org/mailman/listinfo/freebsd-current=0A=
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"=
=0A=
=0A=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YQXPR0101MB0968734764B0226154153930DD2F9>