Date: Tue, 09 Jun 2015 15:41:20 +0200 From: Jan Beich <jbeich@FreeBSD.org> To: Andriy Gapon <avg@FreeBSD.org> Cc: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r284107 - head/sys/cddl/compat/opensolaris/sys Message-ID: <sia1-yp6n-wny@FreeBSD.org> In-Reply-To: <5576CA36.8060403@FreeBSD.org> (Andriy Gapon's message of "Tue, 09 Jun 2015 14:12:54 %2B0300") References: <201506070854.t578sPdR012092@svn.freebsd.org> <twuh-9nr0-wny@FreeBSD.org> <5576CA36.8060403@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Andriy Gapon <avg@FreeBSD.org> writes: > On 09/06/2015 13:31, Jan Beich wrote: > >> Andriy Gapon <avg@FreeBSD.org> writes: >>=20 >>> Author: avg Date: Sun Jun 7 08:54:25 2015 New Revision: 284107 URL: >>> https://svnweb.freebsd.org/changeset/base/284107 >>>=20 >>> Log: compat nvpair.h: make sure that the names are mangled only for >>> kernel >>>=20 >>> Currently there is no good reason to mangle the userland API. The change >>> was introduced in eac1d566b46edef765754203bef22c75c1699966, r279437. >>> Also see https://reviews.freebsd.org/D1881. >>=20 >> Can you bump __FreeBSD_version? At least sysutils/geomWatch requires it. >>=20 >> https://svnweb.freebsd.org/changeset/ports/388906 > > There should have been a bug report and an src fix instead of (parts of) > https://svnweb.freebsd.org/ports?view=3Drevision&revision=3D386870 Good point. However, opensolaris libs have unclear ABI guarantees. Their API is not exposed but the libs aren't marked PRIVATELIB. Some symbols are removed on updates *without* corresponding SHLIB_MAJOR bumps. libnvpair is mostly unchanged between 8.4R and 11.0C, though. # shouldn't be possible without libzfs.so.2 in libmap.conf /poudriere/jails/84amd64/sbin/zfs: Undefined symbol "zpool_set_history_st= r" > I wonder why the libnvpair ABI breakage was silently accepted but the ABI= fix > requires some special magic... I'll probably back out ports@386870 and ports@388906 after a while. libnvpair with bogus ABI existed on 11.0C for 3 months, enough to end up in the binary snapshots a few times. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQF8BAEBCgBmBQJVdu0BXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3bfxUH/2kCi9/CAIjb90ezNIc4a5Bh HmOJAzs0Md+8mTVkSbuTHnsHDlbL8qmh+2QwahyNHAmesNVEFYcjZEbyKyi4yDJR +6/VDTIwKgQcUg0BGPfJGSU7q5sIZv6lvpizYR81uWE4YNkP5j1yCOCIPlfBuiR3 ymhbVipyMdev3tlAh0nhwsXHiQjNJ50C41a9Gl0J4ZWhn50EO1mATGeJ3W9MqfWd PUyH39YZDE+IWpPOfgXYwHyzCbrcAt9EHN7tk/pFKgLdd5vs0ggsh5cYDrIlzpDU l5QjCghc6zBSqDWeFimLkOM/zGN60/Y6VyE9QFIPceLUSfg3tuT1oC30gOzolYU= =ny3y -----END PGP SIGNATURE----- --=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?sia1-yp6n-wny>