Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 11 Mar 2018 23:38:09 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r464197 - head/lang/see
Message-ID:  <20180311233809.GA46270@FreeBSD.org>
In-Reply-To: <201803111946.w2BJkQcD053063@repo.freebsd.org>
References:  <201803111946.w2BJkQcD053063@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 11, 2018 at 07:46:26PM +0000, Sunpoet Po-Chuan Hsieh wrote:
> New Revision: 464197
> URL: https://svnweb.freebsd.org/changeset/ports/464197
> 
> Log:
>   Expand _LICENSE_PERMS_DEFAULT

Again, you're simply translating made changes in English, not actually
explaining them.  This is not right.  It leaves people wondering what
problem are you trying to fix and/or what are you trying to achieve by
these changes.  Please try to add a few words describing those things.

./danfe

> @@ -18,7 +18,7 @@ LICENSE_COMB=	multi
>  LICENSE_NAME_DTOA.C=	License of dtoa.c
>  LICENSE_FILE_BSD3CLAUSE=	${WRKSRC}/COPYING
>  LICENSE_FILE_DTOA.C=	${WRKSRC}/COPYING
> -LICENSE_PERMS_DTOA.C=	${_LICENSE_PERMS_DEFAULT}
> +LICENSE_PERMS_DTOA.C=	dist-mirror dist-sell pkg-mirror pkg-sell auto-accept



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180311233809.GA46270>