Date: Thu, 8 Apr 2010 15:08:35 +0100 From: Rui Paulo <rpaulo@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: Bruce Cran <bruce@cran.org.uk>, freebsd-current@freebsd.org, freebsd-geom@freebsd.org, Teske <dteske@vicor.com>, Randi Harper <randi@freebsd.org>, "Andrey V. Elsukov" <bu7cher@yandex.ru>, =?iso-8859-1?Q?Dag-Erling_Sm=F8rgrav?= <des@des.no>, Alexander Leidinger <Alexander@leidinger.net> Subject: Re: [RFC] Rewriting sade(8) Message-ID: <2FEF9866-2B2E-4AAC-B504-02CF1537AEC0@freebsd.org> In-Reply-To: <201004080849.12151.jhb@freebsd.org> References: <55861270658151@web135.yandex.ru> <20100408103809.13496s9i6ny03ocg@webmail.leidinger.net> <867hoi8gbl.fsf@ds4.des.no> <201004080849.12151.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 8 Apr 2010, at 13:49, John Baldwin wrote: > On Thursday 08 April 2010 5:05:34 am Dag-Erling Smørgrav wrote: >> Alexander Leidinger <Alexander@Leidinger.net> writes: >>> Please consider using SVN instead. A lot more users will be able to >>> check out from there. >> >> We don't grant non-committers access to the Subversion repo. >> >>> It looks like other people had a look at sysinstall, not at sade. As >>> sysinstall is supposed to be used at installation time, and the intent >>> for sade was to offer the functionality (or more) of the part of >>> sysinstall which is useful after installation (and to prevent admins >>> from using sysinstall after the installation to prevent some unwanted >>> foot-shooting), I do not think that we need to think about a strong >>> lock between sysinstall and sade. >> >> Yes we do. Otherwise we'll just end up back where we are today, where >> if you want anything more complicated than a single-disk install you >> have to drop into the fixit shell and do it manually before running the >> installation procedure. Anythig that sade can do, we want sysinstall to >> do as well, and we don't want to implement everything twice. >> >> My suggestion is to add a "sysinstall mode" to sade where it operates >> under certain (minor) constraints and reports what it did in a format >> that sysinstall can parse, so sysinstall can just fork-exec sade instead >> of duplicating the code. > > Actually, I would rather have sysinstall just invoke sade to do the disk > related stuff. Also, I think sysinstall should allow for a "back-door" mode > where a user can setup partitions however they like and mount them at /mnt and > then let sysinstall use the setup the user created. This will allow users to > setup more complex setups that sysinstall/sade do not currently support and > allow sade to focus on simpler, common usage cases w/o having to handle > painful edge cases. It would also allow for new modules to be added to sade > over time w/o requiring it to support every possible disk layout from the > beginning. I couldn't agree more. Regards, -- Rui Paulo
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2FEF9866-2B2E-4AAC-B504-02CF1537AEC0>