Date: Fri, 17 Oct 2008 04:59:32 +0200 From: Max Laier <max@love2party.net> To: freebsd-net@freebsd.org Cc: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> Subject: Re: [patch] src port randomization for inet6 Message-ID: <200810170459.32822.max@love2party.net> In-Reply-To: <20081016130318.J2978@maildrop.int.zabbadoz.net> References: <20081016130318.J2978@maildrop.int.zabbadoz.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday 16 October 2008 15:05:16 Bjoern A. Zeeb wrote: > so since the very early day of src port randomization ipv6 was missing > that part while inet had it. Find a patch below. > Please test, review and report back... > > http://people.freebsd.org/~bz/20081004-07-ipv6-randomport.diff looks good from a casual review. Which is to say that it is in line with the in_pcb.c version. However, I find the comment: /* * Simple check to ensure all ports are not used up causing * a deadlock here. */ a bit dangling and not really in line with the actual code. The same is true for the v4 version. -- /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200810170459.32822.max>