Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 15 Jan 1999 17:06:33 +0100 (CET)
From:      xaa@xaa.iae.nl
To:        FreeBSD-gnats-submit@FreeBSD.ORG
Subject:   bin/9516: ftpd doesn't honor invalid shell in login class
Message-ID:  <19990115160633.95D5A965E@toad.stack.nl>

index | next in thread | raw e-mail


>Number:         9516
>Category:       bin
>Synopsis:       ftpd doesn't honor invalid shelll in login class
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jan 15 08:10:00 PST 1999
>Closed-Date:
>Last-Modified:
>Originator:     Mark Huizer
>Release:        FreeBSD 2.2.7-STABLE i386
>Organization:
MCGV Stack
>Environment:

	2.2.7 and 3.0-current

>Description:

	a user in a login class with an invalid shell (think 'lockout
	class') can ftp to his account without trouble.

>How-To-Repeat:

	create lockout class with /bin/false as shell,change user to
	that class, ftp to his account

>Fix:

patch to libexec/ftpd.c

772a773,775
> #ifdef LOGIN_CAP
> 	login_cap_t *lc = NULL;
> #endif
811a815,825
> #ifdef LOGIN_CAP
> 		lc = login_getpwclass(pw);
> 		if (lc == NULL) {
> 			if ((shell = pw->pw_shell) == NULL || *shell == 0)
> 				shell = _PATH_BSHELL;
> 		} else {
> 			shell = login_getcapstr(lc, "shell", pw->pw_shell, pw->pw_shell);
> 			if (shell==NULL || *shell == 0)
> 				shell = _PATH_BSHELL;
> 		}
> #else
813a828
> #endif
>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19990115160633.95D5A965E>