Date: Mon, 04 Nov 2024 15:02:38 +0000 From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 255309] ice(4) driver doesn't use RSS option correctly Message-ID: <bug-255309-7501-SnskO8xJt8@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-255309-7501@https.bugs.freebsd.org/bugzilla/> References: <bug-255309-7501@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D255309 --- Comment #4 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D6e5650896fe47398e49e3d81af60cc60d= bb09e6e commit 6e5650896fe47398e49e3d81af60cc60dbb09e6e Author: Brian Poole <brian90013@gmail.com> AuthorDate: 2024-10-11 19:57:52 +0000 Commit: Mitchell Horne <mhorne@FreeBSD.org> CommitDate: 2024-11-04 15:01:37 +0000 ice(4): properly use kernel option RSS Header ice_rss.h uses the kernel RSS interface if option RSS is defined. However when ice_rss.h is included by ice_lib.h there is no prior inclusion of ice_opts.h to set RSS causing ifdef RSS to always fail. Add ice_opts.h to the top of ice_lib.h (like ice_iflib.h) so RSS can be defined when ice_rss.h is parsed. With that in place, compilation fails due to a missing defintion of ICE_DEFAULT_RSS_HASH_CONFIG. It is defined in ice_rss.h only when RSS is not defined. Since this define is not part of the kernel RSS interface but ice-specific, it should always be defined. Move its definition outside of ifdef RSS. PR: 255309 Reviewed by: mhorne, erj (earlier version) MFC after: 3 days Pull Request: https://github.com/freebsd/freebsd-src/pull/1460 sys/dev/ice/ice_lib.h | 3 +++ sys/dev/ice/ice_rss.h | 16 ++++++++-------- 2 files changed, 11 insertions(+), 8 deletions(-) --=20 You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-255309-7501-SnskO8xJt8>