Date: Thu, 29 Aug 2024 02:14:56 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 281118] sysutils/munin-node: plugins/zfs_compress will throw an error if the label contains `.`, resulting in data loss. Message-ID: <bug-281118-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D281118 Bug ID: 281118 Summary: sysutils/munin-node: plugins/zfs_compress will throw an error if the label contains `.`, resulting in data loss. Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: flo@FreeBSD.org Reporter: takefu@airport.fm Flags: maintainer-feedback?(flo@FreeBSD.org) Assignee: flo@FreeBSD.org Created attachment 253155 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D253155&action= =3Dedit adhoc to plugins/zfs_compress The munin-master execution log shows the following error and missing data 2024/08/29 00:00:00 [ERROR] config error under [] for 'GROUP1;finger1.north1.airport.fm:zfs_compress.zroot__ROOT__14.1-RELEASE-p1= _2024-07-01_211548.value 1.00' : Parse error in /var/munin/datafile for zfs_compress.zroot__ROOT__14.1-RELEASE-p1_2024-07-01_211548.value: Unknown keyword at end of left hand side of line 7886 (zfs_compress.zroot__ROOT__14.1-RELEASE-p1_2024-07-01_211548.value ) at /usr/local/lib/perl5/site_perl/Munin/Master/Update.pm line 83. # zfs get -t filesystem -H compressratio ..snip.. ZFS/ROOT/14.1-RELEASE-p1_2024-07-04_232340 compressratio 1.00x - # telnet localhost 4949 fetch zfs_compress ..snip.. ZFS__ROOT__14.1-RELEASE-p1_2024-07-04_232340.label ZFS/ROOT/14.1-RELEASE-p1_2024-07-04_232340 ZFS__ROOT__14.1-RELEASE-p1_2024-07-04_232340.value 1.00 The `.` is used for internal separation, but if it is present in the label name, munin-update will behave unexpectedly. I tried to get around this by converting `.` to `_`. # telnet localhost 4949 fetch zfs_compress ..snip.. ZFS__ROOT__14_1-RELEASE-p1_2024-07-04_232340.label ZFS/ROOT/14.1-RELEASE-p1_2024-07-04_232340 ZFS__ROOT__14_1-RELEASE-p1_2024-07-04_232340.value 1.00 This is a minor change that occurs after the patch level is bumped in freebsd-update, so I don't think there's any need to bump PORTREVISION. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-281118-7788>