Date: Wed, 28 Aug 2002 11:45:14 -0700 From: Brooks Davis <brooks@one-eyed-alien.net> To: Nate Lawson <nate@root.org> Cc: Brooks Davis <brooks@one-eyed-alien.net>, scsi@FreeBSD.ORG Subject: Re: [PATCH] make SCSI_DELAY tunable Message-ID: <20020828114514.A7073@Odin.AC.HMC.Edu> In-Reply-To: <Pine.BSF.4.21.0208281122190.77820-100000@root.org>; from nate@root.org on Wed, Aug 28, 2002 at 11:22:49AM -0700 References: <20020828103933.A24804@Odin.AC.HMC.Edu> <Pine.BSF.4.21.0208281122190.77820-100000@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Wed, Aug 28, 2002 at 11:22:49AM -0700, Nate Lawson wrote: > Why the move from scsi_all.h to scsi_all.c for the #defined stuff? It's > needed elsewhere. No it's not. After this patch scsi_all.c is the only consumer of SCSI_DELAY and the old consumers use scsi_delay instead. I moved the #define portion there rather then polluting all files that include scsi_all.h with opt_scsi.h and #defines for variables they shouldn't use. This way helps insure that new consumers of SCSI_DELAY don't appear by accident. -- Brooks -- Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE9bRo2XY6L6fI4GtQRAuuOAJ9ggfvNZR+6h2JWFH/bBcFZfUKdfACgzSdy Ve6IQGRDt+EjtwctTjikW/8= =f1Jp -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020828114514.A7073>