Date: Mon, 23 Jul 2018 10:10:14 -0700 From: Cy Schubert <Cy.Schubert@cschubert.com> To: Ian Lepore <ian@freebsd.org>, Alan Somers <asomers@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: RE: svn commit: r336625 - head/usr.sbin/pw Message-ID: <20180723171011.51FE898A@spqr.komquats.com>
next in thread | raw e-mail | index | archive | help
Unless I'm doing something non-standard (NIS user account Kerberos authenticated) the rev this reverted didn't cause the ssh segfaults, though it may have caused other issues -- I didn't look at Jenkins builds. Reverting r336619 resolved my ssh segfaullt. --- Sent using a tiny phone keyboard. Apologies for any typos and autocorrect. Also, this old phone only supports top post. Apologies. Cy Schubert <Cy.Schubert@cschubert.com> or <cy@freebsd.org> The need of the many outweighs the greed of the few. --- -----Original Message----- From: Ian Lepore Sent: 23/07/2018 08:00 To: Alan Somers Cc: src-committers; svn-src-all@freebsd.org; svn-src-head@freebsd.org Subject: Re: svn commit: r336625 - head/usr.sbin/pw On Mon, 2018-07-23 at 08:53 -0600, Alan Somers wrote: > On Sun, Jul 22, 2018 at 5:41 PM, Ian Lepore <ian@freebsd.org> wrote: > > > > > Author: ian > > Date: Sun Jul 22 23:41:40 2018 > > New Revision: 336625 > > URL: https://svnweb.freebsd.org/changeset/base/336625 > > > > Log: > > Make pw(8) showuser work the same with or without -R <path> for > > non-root > > users. Without -R, pw(8) uses getpwnam(3), which will open > > master.passwd > > for the root user or passwd for non-root users. With -R <path> > > pw(8) was > > always opening <path>/master.passwd, which would fail for a non- > > root > > user, > > then falsely claim the userid you're trying to show doesn't > > exist. > > > > Now for a non-root user it opens <path>/passwd and zeroes out the > > 3 > > fields > > that aren't available in the passwd file, which duplicates the > > behavior > > of > > getpwnam(3). The net effect is that the showuser output is > > identical > > whether using -R or not. > > > > Modified: > > head/usr.sbin/pw/pw_vpw.c > > > It looks like this change has broken approximately all of pw's tests. > Please fix or revert it ASAP. > > https://ci.freebsd.org/job/FreeBSD-head-amd64-test/8320/testReport/ > > BTW, you can easily run these tests by hand, rather than wait for > Jenkins > to do it. If you're not familiar with Kyua/atf, you can do it like > this: > 1) sudo pkg install kyua > 2) cd /usr/tests/usr.sbin/pw > 3) sudo kyua test > 4) sudo kyua report > > -Alan Hrm, it worked with the admittedly simplistic testing I did by hand. I'll look into running the kyua tests and see what's going on; until I get that worked out, it's reverted in r336638. Sorry for the breakage. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180723171011.51FE898A>