Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 17 Dec 2025 10:44:12 +0000
From:      Li-Wen Hsu <lwhsu@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Cc:        Siva Mahadevan <me@svmhdvn.name>
Subject:   git: 6c18c40b29fd - main - lib/msun/tests: xfail fe_round on riscv64
Message-ID:  <6942897c.c120.8b1d408@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch main has been updated by lwhsu:

URL: https://cgit.FreeBSD.org/src/commit/?id=6c18c40b29fd5ac66230af34726260ce2d47aecd

commit 6c18c40b29fd5ac66230af34726260ce2d47aecd
Author:     Siva Mahadevan <me@svmhdvn.name>
AuthorDate: 2025-10-08 20:40:15 +0000
Commit:     Li-Wen Hsu <lwhsu@FreeBSD.org>
CommitDate: 2025-12-17 10:43:19 +0000

    lib/msun/tests: xfail fe_round on riscv64
    
    Replace ATF_CHECK_* with ATF_REQUIRE_* to fail fast and
    avoid unexpected aborts.
    
    Signed-off-by: Siva Mahadevan <me@svmhdvn.name>
    PR:             290099
    MFC after:      3 days
    Sponsored by:   The FreeBSD Foundation
    Pull Request:   https://github.com/freebsd/freebsd-src/pull/1871
---
 contrib/netbsd-tests/lib/libm/t_fe_round.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/contrib/netbsd-tests/lib/libm/t_fe_round.c b/contrib/netbsd-tests/lib/libm/t_fe_round.c
index a7ee3bf77b98..58d1dbfc0e37 100644
--- a/contrib/netbsd-tests/lib/libm/t_fe_round.c
+++ b/contrib/netbsd-tests/lib/libm/t_fe_round.c
@@ -72,20 +72,23 @@ ATF_TC_HEAD(fe_round, tc)
 
 ATF_TC_BODY(fe_round, tc)
 {
+#if defined(__riscv)
+	atf_tc_expect_fail("https://bugs.freebsd.org/290099");
+#endif
 	long int received;
 
 	for (unsigned int i = 0; i < __arraycount(values); i++) {
 		fesetround(values[i].round_mode);
 
 		received = lrint(values[i].input);
-		ATF_CHECK_MSG(
+		ATF_REQUIRE_MSG(
 		    (labs(received - values[i].expected) < EPSILON),
 		    "lrint rounding wrong, difference too large. "
 		    "input: %f (index %d): got %ld, expected %ld",
 		    values[i].input, i, received, values[i].expected);
 
 		/* Do we get the same rounding mode out? */
-		ATF_CHECK_MSG(
+		ATF_REQUIRE_MSG(
 		    (fegetround() == values[i].round_mode),
 		    "Didn't get the same rounding mode out!. "
 		    "(index %d) fed in %d rounding mode, got %d out",


help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6942897c.c120.8b1d408>