Date: Wed, 25 May 2005 22:01:43 -0400 From: Craig Rodrigues <rodrigc@crodrigues.org> To: freebsd-current@freebsd.org Subject: [GCC 4.0 PATCH] devfs_vnops.c Message-ID: <20050526020143.GA80396@crodrigues.org>
next in thread | raw e-mail | index | archive | help
Hi,
When I tried to compile src/sys/fs/devfs/devs_vnops.c
with GCC 4.0, I got the following compilation errors:
/usr/src/sys/fs/devfs/devfs_vnops.c:1389: error: static declaration of 'devfs_vnodeops' follows non-static declaration
/usr/src/sys/fs/devfs/devfs_vnops.c:114: error: previous declaration of 'devfs_vnodeops' was here
/usr/src/sys/fs/devfs/devfs_vnops.c:1411: error: static declaration of 'devfs_specops' follows non-static declaration
/usr/src/sys/fs/devfs/devfs_vnops.c:115: error: previous declaration of 'devfs_specops' was here
Apparently, it is not valid C to define something as extern
and then later on static in the same file, like:
extern struct foo bar;
static struct foo bar = { .... };
What do people think of the following patch to fix it?
http://people.freebsd.org/~rodrigc/devfs_vnops.c.diff.txt
--
Craig Rodrigues
rodrigc@crodrigues.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050526020143.GA80396>