Date: Tue, 24 Jan 2012 15:05:16 -0800 From: Doug Barton <dougb@FreeBSD.org> To: Michael Scheidell <scheidell@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, Jarrod Sayers <jarrod@downtools.com.au>, Gabor Kovesdan <gabor@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/audio/shoutcast Makefile distinfo pkg-plist ports/audio/shoutcast/files pkg-message.in shoutcast.in Message-ID: <4F1F392C.9040807@FreeBSD.org> In-Reply-To: <201201241915.q0OJFFkq063511@repoman.freebsd.org> References: <201201241915.q0OJFFkq063511@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 01/24/2012 11:15, Michael Scheidell wrote: > scheidell 2012-01-24 19:15:15 UTC > > FreeBSD ports repository > > Modified files: > audio/shoutcast Makefile distinfo pkg-plist > audio/shoutcast/files pkg-message.in shoutcast.in > Log: > - Update to 2.0.0.29. > - Bump from beta (build 14) to release (build 29) > - Resolve oddities surrounding PLIST_SUB and SUB_LIST (thanks Michael and Gabor) > - Update pkg-plist to reflect updated documentation > - Support creation of both sc_serv.log and sc_w3c.log on startup > > PR: ports/16440 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=16440 This is not the right PR number. Also, you need "Submitted by:" here. As for the change to the rc.d script itself, it removes the optimization of: required_files="${shoutcast_configfile:="%%PREFIX%%/%%ETCDIR%%/sc_serv.conf"}" which isn't the end of the world if that's what the maintainer wants. (Same goes for changing the literal shoutcast to $name.) However it also removed the required_dirs="${shoutcast_chdir}" which is probably not a good idea. Also, %%SHOUTCASTUSER%% in the chown line should be ${shoutcast_user} but I think that was probably a bug in my previous patch, so sorry about that. However, the touch/chown/chmod lines add "" around each variable, which is almost certainly unnecessary. A better way to handle this situation (substantial changes to the script by the maintainer after it was already changed by another developer) would have been to start a dialog about the changes before committing them. Ideally on the freebsd-rc@ or freebsd-ports@ lists. Doug > Approved by: gabor (mentor) > > Revision Changes Path > 1.22 +11 -10 ports/audio/shoutcast/Makefile > 1.9 +2 -2 ports/audio/shoutcast/distinfo > 1.4 +1 -1 ports/audio/shoutcast/files/pkg-message.in > 1.3 +15 -12 ports/audio/shoutcast/files/shoutcast.in > 1.4 +3 -1 ports/audio/shoutcast/pkg-plist > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/audio/shoutcast/Makefile.diff?&r1=1.21&r2=1.22&f=u > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/audio/shoutcast/distinfo.diff?&r1=1.8&r2=1.9&f=u > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/audio/shoutcast/files/pkg-message.in.diff?&r1=1.3&r2=1.4&f=u > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/audio/shoutcast/files/shoutcast.in.diff?&r1=1.2&r2=1.3&f=u > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/audio/shoutcast/pkg-plist.diff?&r1=1.3&r2=1.4&f=u > -- It's always a long day; 86400 doesn't fit into a short. Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F1F392C.9040807>