Date: Tue, 03 Mar 2009 03:16:14 -0800 From: Timothy Beyer <beyert@cs.ucr.edu> To: FreeBSD-gnats-submit@FreeBSD.org Cc: Timothy Beyer <beyert@cs.ucr.edu> Subject: ports/132280: audio/snd: Fix guile support, add motif support Message-ID: <87myc2g8ld.wl%beyert@cs.ucr.edu> Resent-Message-ID: <200903031120.n23BK4Oo087988@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 132280
>Category: ports
>Synopsis: audio/snd: Fix guile support, add motif support
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Tue Mar 03 11:20:04 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Timothy Beyer
>Release: FreeBSD 7.1-RELEASE-p2 i386
>Organization:
no organization
>Environment:
System: FreeBSD aeonserv.aeonnet 7.1-RELEASE-p2 FreeBSD 7.1-RELEASE-p2 #4: Sun Jan 25 21:45:53 PST 2009 beyert@aeonserv.aeonnet:/usr/obj/usr/src/sys/CUSTOM i386
>Description:
This patch makes the following changes:
-Adds --with-guile so that guile is actually enabled when guile is selected (currently, if guile is selected, it doesn't install any extension language -- this is because snd's default extension language is now s7)
-Adds support for Motif (the X11 option is now decoupled from GTK, if GTK support is desired, use the GTK and the X11 knobs; Similarly, if Motif is desired, select both the X11 and Motif options.)
On a side note, currently if S7 support is enabled, snd will not compile. If I come up with a patch, I will file a PR. Please don't disable the option; I think it will become the only scheme supported eventually, so fixing it should be an eventual priority.
>How-To-Repeat:
-Enable guile and run snd --help after snd is installed
-Enable X11 and GTK or X11 and Motif
-Try enabling the S7 option (it won't compile)
>Fix:
The following patches:
--- Makefile.diff begins here ---
--- Makefile.orig 2009-02-27 15:30:14.000000000 -0800
+++ Makefile 2009-03-03 02:32:39.000000000 -0800
@@ -22,7 +22,9 @@
LADSPA "Include support for LADSPA plugins" on \
NLS "Native Language Support" on \
RUBY "Use Ruby as the extension language" off \
- X11 "Make Snd with Gtk+ graphics support" on
+ MOTIF "Make Snd with Motif graphics support" on \
+ GTK "Make Snd with Gtk+ graphics support" off \
+ X11 "Make Snd with GUI support" on
USE_GNOME= gnometarget
GNU_CONFIGURE= yes
@@ -61,6 +63,7 @@
.endif
.if !defined(WITHOUT_GUILE)
+CONFIGURE_ARGS+= --with-guile
LIB_DEPENDS+= guile.20:${PORTSDIR}/lang/guile
PLIST_SUB+= SCHEME=""
.else
@@ -96,14 +99,20 @@
PLIST_SUB+= SCHEME="@comment "
.endif
-.if defined(WITHOUT_X11)
-CONFIGURE_ARGS+= --with-no-gui
-PLIST_SUB+= X11="@comment "
-.else
+.if defined(WITH_GTK)
USE_GNOME+= gtk20
CONFIGURE_ARGS+= --with-gtk
PLIST_SUB+= X11=""
.endif
+.if defined(WITH_MOTIF)
+CONFIGURE_ARGS+= --with-motif
+PLIST_SUB+= X11=""
+.endif
+
+.if defined(WITHOUT_X11)
+CONFIGURE_ARGS+= --with-no-gui
+PLIST_SUB+= X11="@comment "
+.endif
post-patch:
@${REINPLACE_CMD} -e 's|^ _Complex| Vaiolate _Complex|g ; \
--- Makefile.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?87myc2g8ld.wl%beyert>