Date: Sun, 12 Sep 2004 04:37:53 +0200 (CEST) From: Dan Lukes <dan@obluda.cz> To: FreeBSD-gnats-submit@FreeBSD.org Subject: bin/71622: [PATCH] cleanup of the usr.sbin/sicontrol code Message-ID: <200409120237.i8C2brW3007104@kulesh.obluda.cz> Resent-Message-ID: <200409120240.i8C2eQaF087029@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 71622
>Category: bin
>Synopsis: [PATCH] cleanup of the usr.sbin/sicontrol code
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun Sep 12 02:40:26 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator: Dan Lukes
>Release: FreeBSD 5.3-BETA3 i386
>Organization:
Obludarium
>Environment:
System: FreeBSD kulesh.obluda.cz 5.3-BETA3 FreeBSD 5.3-BETA3 #8: Sun Sep 5 07:06:40 CEST 2004 dan@kulesh.obluda.cz:/usr/obj/usr/src/sys/Dan i386
usr.sbin/sicontrol/sicontrol.c,v 1.14 2004/08/07 04:28:55 imp
>Description:
There are more than 5000 warnings issued during "make buildworld".
Some of them are false positives, but some of them are sign of true errors.
Nobody is upset by warnings due it's amount, so some errors remain
uncorrected.
I want to cleanup the code-base from warnings, so warnings will
become "attention mark" again.
usr.sbin/sicontrol/sicontrol.c:472: warning: unsigned int format, pointer arg (arg 2)
>How-To-Repeat:
N/A
>Fix:
*** usr.sbin/sicontrol/sicontrol.c.ORIG Sun Aug 8 21:14:06 2004
--- usr.sbin/sicontrol/sicontrol.c Tue Sep 7 19:26:59 2004
***************
*** 469,475 ****
printf("%s: ", Devname);
printf("\tt_outq.c_cc %d.\n", TTY.t_outq.c_cc); /* struct clist t_outq */
! printf("\tt_dev 0x%x\n", TTY.t_dev); /* dev_t t_dev */
printf("\tt_flags 0x%x\n", TTY.t_flags); /* int t_flags */
printf("\tt_state 0x%x\n", TTY.t_state); /* int t_state */
printf("\tt_ihiwat %d.\n", TTY.t_ihiwat); /* int t_ihiwat */
--- 469,475 ----
printf("%s: ", Devname);
printf("\tt_outq.c_cc %d.\n", TTY.t_outq.c_cc); /* struct clist t_outq */
! printf("\tt_dev %p\n", TTY.t_dev); /* struct cdev *t_dev */
printf("\tt_flags 0x%x\n", TTY.t_flags); /* int t_flags */
printf("\tt_state 0x%x\n", TTY.t_state); /* int t_state */
printf("\tt_ihiwat %d.\n", TTY.t_ihiwat); /* int t_ihiwat */
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200409120237.i8C2brW3007104>