Date: Wed, 14 Dec 2005 09:40:54 +0100 (CET) From: Sten Spans <sten@blinkenlights.nl> To: Andrew Thompson <thompsa@freebsd.org> Cc: freebsd-net@freebsd.org Subject: Re: m_copypacket in if_bridge Message-ID: <Pine.SOC.4.61.0512140938410.5102@tea.blinkenlights.nl> In-Reply-To: <20051214022353.GB5248@heff.fud.org.nz> References: <20051214022353.GB5248@heff.fud.org.nz>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 14 Dec 2005, Andrew Thompson wrote: > Hi, > > > I have realised that if_bridge uses m_copypacket() in an unsafe way. > The copied multicast packet is sent back into ether_input for local > processing so that ipv6 works but m_copypacket() returns a readonly > mbuf. The layer3 header needs to be aligned so I have changed this to > m_dup+m_copyup. > > Can I get a review to ensure this is the correct fix This certainly looks like a reasonable fix. Thanks for making life better for sparc and alpha :) -- Sten Spans "There is a crack in everything, that's how the light gets in." Leonard Cohen - Anthem
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.SOC.4.61.0512140938410.5102>