Date: Sun, 10 Feb 2008 14:34:30 +0000 (GMT) From: Robert Watson <rwatson@FreeBSD.org> To: Attilio Rao <attilio@freebsd.org> Cc: Kostik Belousov <kostikbel@gmail.com>, cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/sys lockmgr.h Message-ID: <20080210143313.W90254@fledge.watson.org> In-Reply-To: <3bbf2fe10802100449r1b673bbfl3e41a419b08c0@mail.gmail.com> References: <200802092137.m19Lbsiu098036@repoman.freebsd.org> <20080210113949.GN57756@deviant.kiev.zoral.com.ua> <20080210120359.A97821@fledge.watson.org> <3bbf2fe10802100449r1b673bbfl3e41a419b08c0@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 10 Feb 2008, Attilio Rao wrote: >> > I think this shall be MFCed to RELENG_7 and RELENG_7_0. >> >> ... once it no longer breaks the tinderbox? >> >> BTW, at this point 7.0 is basically closed to any further changes. Anyone >> planning on getting things in to 7.x needs to be thinking about either >> errata notices (for really critical things) and 7.1. > > Buh! I'm very sorry for this. Really, this needed to be better croaked. It > needs to include sys/lock.h for any lockmgr.h consumer (making lock.h a > pre-requirement in lockmgr usage). This is going to be a little bit of work. > > For the moment I will revert this change, doing a better stub later, once > other details about lockmgr are refined. Or temporarily nested include lock.h from lockmgr.h. I'm pretty sure that all consumers of struct lock pretty much include _lock.h, so if there's a widespread dependency you could also move whatever the definitions are to _lock.h. Robert N M Watson Computer Laboratory University of Cambridge
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080210143313.W90254>