Date: Wed, 8 Feb 2006 17:30:34 +0100 From: Harald Schmalzbauer <h.schmalzbauer@omnisec.de> To: Gleb Smirnoff <glebius@freebsd.org> Cc: cvs-src@freebsd.org, freebsd-current@freebsd.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h Message-ID: <200602081730.35748.h.schmalzbauer@omnisec.de> In-Reply-To: <20060112220112.GE83922@FreeBSD.org> References: <200601110030.k0B0UPOx009098@repoman.freebsd.org> <200601121847.08044@harrymail> <20060112220112.GE83922@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Am Donnerstag, 12. Januar 2006 23:01 schrieb Gleb Smirnoff: > On Thu, Jan 12, 2006 at 06:47:00PM +0100, Harald Schmalzbauer wrote: > H> Am Mittwoch, 11. Januar 2006 01:30 CEST schrieb Scott Long: > H> > scottl 2006-01-11 00:30:25 UTC > H> > > H> > FreeBSD src repository > H> > > H> > Modified files: > H> > sys/dev/em if_em.c if_em.h > H> > Log: > H> > Significant performance improvements for the if_em driver: > H> > > H> > - Only update the rx ring consumer pointer after running through the > H> > rx loop, not with each iteration through the loop. > H> > - If possible, use a fast interupt handler instead of an ithread > H> > handler. Use the interrupt handler to check and squelch the > interrupt, H> > then schedule a taskqueue to do the actual work. This has > three H> > benefits: > H> > H> Thank you very much for your work! Since I'm using many em cards and > can't H> get higher tranfer rates compared to fxp (but I wanted to double > it so I H> spent some money to replace F-Eth equipment with GbE) I'd like > to apply H> your work to RELENG_6. I made the attached diff, but compiler > stops here: H> [...] > H> /usr/src/sys/dev/em/if_em.c:3178:34: macro "VLAN_INPUT_TAG" requires 4 > H> arguments, but only 3 given > H> mkdep: compile failed > H> *** Error code 1 > H> > H> Stop in /usr/obj/GUNE/usr/src/sys/CUV-LV. > H> *** Error code 1 > H> > H> I have no idea how to correct this, could you please help me? Or isn't > it H> that simple, eg. VLAN isn't the same level in RELENG_6 and -current? > > I'm going to merge the VLAN_INPUT_TAG() change soon. But merging em(4) > requires also a lot of taskqueue code merging. Thanks for your work, I saw that you merged the VLAN code some time ago to RELENG_6. Is there any chance that the taskqueue code and then the new em code will make it into 6.1? I'd really love to see my em's shifting more than 130mbit/s with ftp... ;) -Harry
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200602081730.35748.h.schmalzbauer>