Date: Sun, 27 Jul 2008 23:24:09 +0200 From: Ivan Voras <ivoras@freebsd.org> To: freebsd-fs@freebsd.org Cc: freebsd-current@freebsd.org Subject: Re: ZFS patches. Message-ID: <g6ip21$i8u$1@ger.gmane.org> In-Reply-To: <20080727125413.GG1345@garage.freebsd.pl> References: <20080727125413.GG1345@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] Pawel Jakub Dawidek wrote: > Hi. > > http://people.freebsd.org/~pjd/patches/zfs_20080727.patch.bz2 > > The patch above contains the most recent ZFS version that could be found > in OpenSolaris as of today. Apart for large amount of new functionality, > I belive there are many stability (and also performance) improvements > compared to the version from the base system. > > Check out OpenSolaris website to find out the differences between base > system version and patch version. > > Please test, test, test. If I get enough positive feedback, I may be > able to squeeze it into 7.1-RELEASE, but this might be hard. I'm trying to test it, and my build fails at an unusual place - dtrace. I've verified that a clean cvsup tree compiles the dtrace modules, and it fails with the same tree patched with the above patch. Any ideas? The exact command for applying the patch was: wbench:/usr/src# patch -p0 < ~ivoras/zfs_20080727.patch The failure is: ===> dtmalloc (all) Warning: Object directory not changed from original /usr/src/sys/modules/dtrace/dtmalloc cc -O2 -fno-strict-aliasing -pipe -Werror -D_KERNEL -DKLD_MODULE -std=c99 -nostdinc -I/usr/src/sys/modules/dtrace/dtmalloc/../../../cddl/compat/opensolaris -I/usr/src/sys/modules/dtrace/dtmalloc/../../../cddl/contrib/opensolaris/uts/common -I/usr/src/sys/modules/dtrace/dtmalloc/../../.. -I. -I@ -I@/contrib/altq -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-common -mno-align-long-strings -mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -Wno-unknown-pragmas -c /usr/src/sys/modules/dtrace/dtmalloc/../../../cddl/dev/dtmalloc/dtmalloc.c In file included from /usr/src/sys/modules/dtrace/dtmalloc/../../../sys/vnode.h:541, from /usr/src/sys/modules/dtrace/dtmalloc/../../../cddl/contrib/opensolaris/uts/common/sys/vnode.h:44, from /usr/src/sys/modules/dtrace/dtmalloc/../../../cddl/compat/opensolaris/sys/vnode.h:43, from /usr/src/sys/modules/dtrace/dtmalloc/../../../cddl/compat/opensolaris/sys/kobj.h:41, from /usr/src/sys/modules/dtrace/dtmalloc/../../../sys/linker.h:35, from /usr/src/sys/modules/dtrace/dtmalloc/../../../cddl/compat/opensolaris/sys/modctl.h:34, from /usr/src/sys/modules/dtrace/dtmalloc/../../../cddl/contrib/opensolaris/uts/common/sys/dtrace.h:50, from /usr/src/sys/modules/dtrace/dtmalloc/../../../cddl/dev/dtmalloc/dtmalloc.c:35: ./vnode_if.h:1161: error: expected specifier-qualifier-list before 'acl_type_t' ./vnode_if.h:1174: error: expected declaration specifiers or '...' before 'acl_type_t' cc1: warnings being treated as errors ./vnode_if.h:1177: warning: 'struct acl' declared inside parameter list ./vnode_if.h:1177: warning: its scope is only this definition or declaration, which is probably not what you want ./vnode_if.h: In function 'VOP_GETACL': ./vnode_if.h:1183: error: 'struct vop_getacl_args' has no member named 'a_type' ./vnode_if.h:1183: error: 'type' undeclared (first use in this function) This is -current from a few minutes ago, i386, GENERIC kernel with INVARIANTS and WITNESS (and their supporting options) removed. Excerpt from vnode_if.h: 1158 struct vop_getacl_args { 1159 struct vop_generic_args a_gen; 1160 struct vnode *a_vp; 1161 acl_type_t a_type; 1162 struct acl *a_aclp; 1163 struct ucred *a_cred; 1164 struct thread *a_td; 1165 }; [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.5 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIjOd/ldnAQVacBcgRAo9/AJ9G8del2ewKm3hSqaCWbiLV9hTgbwCfbJ2O P2+J8zAGDXO3WGan0nKFdXs= =mE0o -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?g6ip21$i8u$1>