Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 12 Jun 2007 21:13:41 GMT
From:      Ulf Lilleengen <lulf@FreeBSD.org>
To:        Perforce Change Reviews <perforce@FreeBSD.org>
Subject:   PERFORCE change 121537 for review
Message-ID:  <200706122113.l5CLDfFO099158@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=121537

Change 121537 by lulf@lulf_carrot on 2007/06/12 21:12:41

	- Print out error codes when we get them.

Affected files ...

.. //depot/projects/soc2007/lulf/gvinum_fixup/sys/geom/vinum/geom_vinum.c#15 edit
.. //depot/projects/soc2007/lulf/gvinum_fixup/sys/geom/vinum/geom_vinum_rm.c#6 edit

Differences ...

==== //depot/projects/soc2007/lulf/gvinum_fixup/sys/geom/vinum/geom_vinum.c#15 (text+ko) ====

@@ -609,7 +609,7 @@
 				 * ERROR CODES.*/
 				if (err)
 					printf("VINUM: error setting subdisk "
-					    "state\n");
+					    "state: error code %d\n", err);
 				g_free(ev->arg2);
 				g_free(ev->arg3);
 				break;
@@ -624,7 +624,7 @@
 				 * ERROR CODES.*/
 				if (err)
 					printf("VINUM: error setting drive "
-					    "state\n");
+					    "state: error code %d\n", err);
 				g_free(ev->arg2);
 				g_free(ev->arg3);
 				break;
@@ -637,7 +637,7 @@
 				err = gv_set_vol_state(v, newstate, flags);
 				if (err)
 					printf("VINUM: error setting volume "
-					    "state\n");
+					    "state: error code %d\n", err);
 				g_free(ev->arg2);
 				g_free(ev->arg3);
 				break;
@@ -650,7 +650,7 @@
 				err = gv_set_plex_state(p, newstate, flags);
 				if (err)
 					printf("VINUM: error setting plex "
-					    "state\n");
+					    "state: error code %d\n", err);
 				g_free(ev->arg2);
 				g_free(ev->arg3);
 				break;
@@ -660,7 +660,7 @@
 				err = gv_resetconfig(sc);
 				if (err)
 					printf("VINUM: error resetting config: "
-					    "%d\n", err);
+					    "error code %d\n", err);
 				break;
 
 			case GV_EVENT_PARITY_REBUILD:
@@ -713,7 +713,8 @@
 				err = gv_attach_plex(p, v, 0);
 				if (err)
 					printf("VINUM: error attaching %s to "
-					    "%s\n", p->name, v->name);
+					    "%s: error code %d\n", p->name,
+					    v->name, err);
 				break;
 
 			case GV_EVENT_ATTACH_SD:
@@ -723,7 +724,8 @@
 				err = gv_attach_sd(s, p, -1, 0);
 				if (err)
 					printf("VINUM: error attaching %s to "
-					    "%s\n", s->name, p->name);
+					    "%s: error code %d\n", s->name,
+					    p->name, err);
 				break;
 
 			case GV_EVENT_DETACH_PLEX:
@@ -731,8 +733,8 @@
 				p = ev->arg1;
 				err = gv_detach_plex(p, 0);
 				if (err)
-					printf("VINUM: error detaching %s\n",
-					    p->name);
+					printf("VINUM: error detaching %s: "
+					    "error code %d\n", p->name, err);
 				break;
 
 			case GV_EVENT_DETACH_SD:
@@ -740,8 +742,8 @@
 				s = ev->arg1;
 				err = gv_detach_sd(s, 0);
 				if (err)
-					printf("VINUM: error detaching %s\n",
-					    s->name);
+					printf("VINUM: error detaching %s: "
+					    "error code %d\n", p->name, err);
 				break;
 
 			case GV_EVENT_THREAD_EXIT:

==== //depot/projects/soc2007/lulf/gvinum_fixup/sys/geom/vinum/geom_vinum_rm.c#6 (text+ko) ====




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200706122113.l5CLDfFO099158>