Date: Tue, 10 Dec 2019 19:27:55 +1100 From: Peter Jeremy <peter@rulingia.com> To: Michal Meloun <mmel@freebsd.org> Cc: Kyle Evans <kevans@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r355487 - in head/sys: arm64/arm64 arm64/include conf Message-ID: <20191210082755.GA31003@server.rulingia.com> In-Reply-To: <CACNAnaEcn9_Wc=_z4MOP%2B4nh%2Bgu5N4%2BUusVnT1QjAGvJJgUyRA@mail.gmail.com> References: <201912071614.xB7GENQ3080793@repo.freebsd.org> <CACNAnaEcn9_Wc=_z4MOP%2B4nh%2Bgu5N4%2BUusVnT1QjAGvJJgUyRA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--WIyZ46R2i8wDzkSu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On 2019-Dec-09 08:38:01 -0600, Kyle Evans <kevans@freebsd.org> wrote:
=2E..
>> +static vm_offset_t
>> +freebsd_parse_boot_param(struct arm64_bootparams *abp)
>> +{
>> + vm_offset_t lastaddr =3D 0;
>> + void *kmdp;
>> +#ifdef DDB
>> + vm_offset_t ksym_start;
>> + vm_offset_t ksym_end;
>> +#endif
>> +
>> + if (abp->modulep =3D=3D 0)
>> + return (0);
>> +
>> + preload_metadata =3D (caddr_t)(uintptr_t)(abp->modulep);
>> + kmdp =3D preload_search_by_type("elf kernel");
>> + if (kmdp =3D=3D NULL)
>> + return (0);
>> +
>> + boothowto =3D MD_FETCH(kmdp, MODINFOMD_HOWTO, int);
>> + loader_envp =3D MD_FETCH(kmdp, MODINFOMD_ENVP, char *);
>> + init_static_kenv(static_kenv, 0);
>
>This should read "loader_envp" instead of "static_kenv" -- as written,
>it stomps over the kenv provided by loader.
Which breaks diskless booting and NFS root. Changing static_kenv to
loader_envp unbreaks the kernel.
--=20
Peter Jeremy
--WIyZ46R2i8wDzkSu
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQKTBAEBCgB9FiEE7rKYbDBnHnTmXCJ+FqWXoOSiCzQFAl3vVvJfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEVF
QjI5ODZDMzA2NzFFNzRFNjVDMjI3RTE2QTU5N0EwRTRBMjBCMzQACgkQFqWXoOSi
CzRSPA/8Czk5dO7sN067HIULDFqg5oG0zHWw+aLh2tybNu6YYWBaBNTGDlbF2+J+
u7VzTNry9HZmunHKsWG8Ui7DYP2vSdvcZTj/QGo7KO1Q8mds5J4dEOSpZbcIENAi
1jF56XHjBwpG9UKudGqtb6BcAUWI4tvwhXe3xVttwgWdF4Xj65WFWjAe4N8147er
3IIZJA4dBfcy88/qvVza100ktj8Gs89nV1AkX6UXJPu4U7PI6zZ62yXBA7ND+7nx
Xolnd0d3JNsD/MKqtjbn7ogwVHnY4nahua8A8yUoqo9Nl5borKgWRIP1S9c2MTuW
kCE8tchsa813+vsF4+Bb97uLd8leVA9HBvllVCG1ysLzJ0amc7R98F2EGEM1R2Lk
UwPOBgCa0xge5L/SMxZJQA6PGT+hlf85Cpg7Edi9T9Jd/G5kh3QTWNt3s7aC+fXG
BOvgEUwqLkZC16TZracrsOztpTgRwnH9e7SILI2uq1kCn8bbwjfKdVUmi0ROZ35B
E9UorbE6U9pKteOUNkBgaeeelcWEN/SB55aS0w0oRqDEBD2kS21E/YepumPVUG0F
62KJwVewk3d3k9j6twYWEalD5vVJ1dRBmoPnswfnQLOWQ45wd0CW2tc6cbo8ycex
W6LfeMeX1cT4cdM/kBHSliomX4YpBI2tggkfgaa0IOiECErUqzU=
=vlyy
-----END PGP SIGNATURE-----
--WIyZ46R2i8wDzkSu--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191210082755.GA31003>