Date: Tue, 09 Dec 2008 17:09:05 -0800 From: Maxim Sobolev <sobomax@sippysoft.com> To: pav@FreeBSD.ORG Cc: cvs-ports@FreeBSD.ORG, Alexey Dokuchaev <danfe@FreeBSD.ORG>, cvs-all@FreeBSD.ORG, ports-committers@FreeBSD.ORG Subject: Re: cvs commit: ports/net/asterisk Makefile Message-ID: <493F16B1.3020409@sippysoft.com> In-Reply-To: <1228858485.917.4.camel@hood.oook.cz> References: <200812090602.mB962eiw090973@repoman.freebsd.org> <20081209191509.GA50518@FreeBSD.org> <493ED4B6.4010409@sippysoft.com> <1228858485.917.4.camel@hood.oook.cz>
next in thread | previous in thread | raw e-mail | index | archive | help
Pav Lucistnik wrote:
> Maxim Sobolev píše v út 09. 12. 2008 v 12:27 -0800:
>
>>>> sobomax 2008-12-09 06:02:40 UTC
>>>>
>>>> FreeBSD ports repository
>>>>
>>>> Modified files:
>>>> net/asterisk Makefile
>>>> Log:
>>>> Convert all WITHOUT_XXX options into WITH_XXX form. OPTIONS system
>>>> only really supports the latter.
>>> I've always been under impression that OPTIONS support both. Can you
>>> please point to bpm/bom revisions where it was broken?
>> Maybe I did not make myself clear, by "not supported" I have meant that
>> in BATCH mode the mk is not automatically generating WITHOUT_XXX
>> definitions for the items that are supposed to be off by default. You
>> can get more details in the PR mentioned in the commit message.
>
> Not true since bsd.port.mk rev. 1.559, I think.
OK, further investigation shows that it doesn't happen to OPTIONS added
after .include <bsd.port.pre.mk>:
Today's ports (1.604 of bsd.port.mk), FreeBSD/amd64,:
[sobomax@pioneer ~]$ cd /usr/ports/net/asterisk
[sobomax@pioneer /usr/ports/net/asterisk]$ sudo rm -rf /var/db/ports
[sobomax@pioneer /usr/ports/net/asterisk]$ make -DBATCH -V WITHOUT_ZAPTEL
[sobomax@pioneer /usr/ports/net/asterisk]$ make -DBATCH -V WITHOUT_ILBC
true
The difference is that ZAPTEL is defined after .include <bsd.port.pre.mk>:
-----
OPTIONS= OGGVORBIS "Enable Ogg Vorbis support" on \
ODBC "Enable ODBC support" on \
POSTGRES "Enable PostgreSQL support" on \
RADIUS "Enable RADIUS accounting support" on \
SNMP "Enable SNMP support" on \
H323 "Enable H.323 support" on \
FREETDS "Enable FreeTDS support" on \
JABBER "Enable Jabber and Gtalk support" on \
SQLITE "Enable SQLITE support" on \
CODEC_PATCH "Apply codec negotiation patch" off \
ILBC "Enable iLBC codec" off \
MISC_PATCHES "Apply additional patches" off
.include <bsd.port.pre.mk>
.if ${ARCH} == "i386" || ${ARCH} == "amd64"
OPTIONS+= ZAPTEL "Enable Zaptel support" off
.endif
-----
Looks like a bug in bsd.port.mk to me.
-Maxim
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?493F16B1.3020409>