Date: Tue, 3 Jun 2014 12:43:43 -0600 From: Warner Losh <imp@bsdimp.com> To: John-Mark Gurney <jmg@funkthat.com> Cc: freebsd-scsi@freebsd.org Subject: Re: Review needed Message-ID: <8FE17C18-08AB-4324-A059-D277792CC630@bsdimp.com> In-Reply-To: <20140603182252.GF31367@funkthat.com> References: <D530E825-A507-41D6-9ABE-A2A7F8F95394@bsdimp.com> <20140603182252.GF31367@funkthat.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_A8799E54-CDDB-4584-A0CB-D400B8AC3C11 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Jun 3, 2014, at 12:22 PM, John-Mark Gurney <jmg@funkthat.com> wrote: > Warner Losh wrote this message on Mon, Jun 02, 2014 at 10:46 -0600: >> The code that combines adjacent ranges for BIO_DELETEs to optimize >> trims to the device assumes the list is sorted. Don't apply the >> optimization of not sorting the queue when we have SSDs to the >> delete_queue, since it causes more discard traffic to the drive. = While >=20 > I'm puzzled by this statement, if I remove the double negative, I get: > Do apply the optimization of sorting the queue when we have SSDs to = the > delete_queue, since it (what the new optimizations?) causes more = discard > traffic to the drive. >=20 > Do you mean previously? Yes, it should reduce traffic because sorting allows ranges to be = collapsed. it =3D=3D the lack of sorting I=92ll tweak the commit message to be less opaque. >> one could argue that the higher levels should coalesce the trims, >> that's not done today, so some optimization at this level is needed. >>=20 >> Diffs and a (hopefully) cool review tool: = https://phabric.freebsd.org/D142 >=20 > Please include a raw diff... A Phabric is only for FreeBSD = committers, > it takes the rest of the community out of the ability to review. I thought people w/o an account could at least see the diff. Looks like = that=92s not the case (and somewhat lame). You can get the same thing from my hg patch queue: http://people.freebsd.org/~imp/patch-queue/bio_delete Warner --Apple-Mail=_A8799E54-CDDB-4584-A0CB-D400B8AC3C11 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJTjhdfAAoJEGwc0Sh9sBEA94wQAKiVXPit6Sy85kaa7rlRqDyY 0W154CrfXXAAKhhROabcNTopEYwYYaIPlHlrYc3aqGa33rmfcu5uD8befWMA5FZg 9dtgWsKp5W3nAuGiCA3b+JskCkU2Ki1DU0PGY731jPMmfQ/oVeoMVB+Xbgd+cymX DfVSsjx167+9z+COR+efSag2kkR8c8tmb9AI8d/qhcGZGv1juD7Ci4gR1A7jxyb6 PQNlOBcyUNv5YKgSLFW5svpuwuqY6Yei4M7X5VzmDJH3xJ3/dKxYkX0jnk5+UPNX Or4vIYk3RnUudfqAkB/FDD/FeBj2qTNjvmn3L/hbVf4iADmDkGhHxJcrI9GEoMn+ +UEimmvs+GJ0JgZj7YsFdVAbNTJL4aXPp94pitz07dDkxIMrcoUWHAsLqPjcqg1V ucuO43tLdMPwXFAwW/g26dmPnjiVRNY2bdwcsXu/3aOD2lbw6vd22gdzY8OOvpA/ x3e8pYYcY8BUdYId1uH05jPdUqcKgX5YhElZZ5DZHYg9cZg1ywjHCyJVgL9uYeRg TtwuFjdQ/rJWy/Shw7QseP2v4849OTLDpMeVKc5GngoSm7BWpcwA5onBMv20YFDL kxc3sHLRmEtNJ5uA9tFEk9JkyDwHO4smhzKTZO5cfO85PNfb+C2t926zkZ75I7LH 6ws4/r4VBf8SfQiu8dXO =gTeQ -----END PGP SIGNATURE----- --Apple-Mail=_A8799E54-CDDB-4584-A0CB-D400B8AC3C11--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8FE17C18-08AB-4324-A059-D277792CC630>