Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 28 Jun 2024 10:17:51 GMT
From:      Mariusz Zaborski <oshogbo@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 7fa105d91f0d - stable/13 - isp: fix ISPCTL_ABORT_CMD switch case
Message-ID:  <202406281017.45SAHpcM075776@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by oshogbo:

URL: https://cgit.FreeBSD.org/src/commit/?id=7fa105d91f0dd31d55d178811cc5a62f6fdbd501

commit 7fa105d91f0dd31d55d178811cc5a62f6fdbd501
Author:     Mariusz Zaborski <oshogbo@FreeBSD.org>
AuthorDate: 2024-06-25 14:50:28 +0000
Commit:     Mariusz Zaborski <oshogbo@FreeBSD.org>
CommitDate: 2024-06-28 10:19:14 +0000

    isp: fix ISPCTL_ABORT_CMD switch case
    
    Prevent kernel panic by not running ISPCTL_FCLINK_TEST after a
    failed ISPCTL_ABORT_CMD.
    
    Reviewed by:    mav
    Tested by:      Arne Steinkamm <arne@steinkamm.com>
    MFC after:      3 days
    Differential Revision:  https://reviews.freebsd.org/D45718
    
    (cherry picked from commit 8aa9192ce98aec07b24f8279c709237dd2c4421b)
---
 sys/dev/isp/isp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sys/dev/isp/isp.c b/sys/dev/isp/isp.c
index b53171add5f5..ad6dbd1e6f76 100644
--- a/sys/dev/isp/isp.c
+++ b/sys/dev/isp/isp.c
@@ -3088,6 +3088,7 @@ isp_control(ispsoftc_t *isp, ispctl_t ctl, ...)
 		if (ab->abrt_nphdl == ISP24XX_ABRT_OKAY)
 			return (0);
 		isp_prt(isp, ISP_LOGWARN, "Chan %d handle %d abort returned 0x%x", chan, tgt, ab->abrt_nphdl);
+		break;
 	}
 	case ISPCTL_FCLINK_TEST:
 	{



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202406281017.45SAHpcM075776>