Date: Wed, 21 Sep 2005 10:31:32 GMT From: Robert Watson <rwatson@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 84038 for review Message-ID: <200509211031.j8LAVWst039557@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=84038 Change 84038 by rwatson@rwatson_zoo on 2005/09/21 10:31:16 Don't unconditionally assert Giant when auditing a path -- rely on the caller to acquire Giant if needed, and assert based on need. Affected files ... .. //depot/projects/trustedbsd/audit3/sys/security/audit/kern_audit.c#30 edit Differences ... ==== //depot/projects/trustedbsd/audit3/sys/security/audit/kern_audit.c#30 (text+ko) ==== @@ -2359,9 +2359,10 @@ return; /* - * XXXAUDIT: Less Giant needed here. + * Assume that if the caller is calling audit_arg_vnpath() on a + * non-MPSAFE vnode, then it will have acquired Giant. */ - mtx_assert(&Giant, MA_OWNED); + VFS_ASSERT_GIANT(vp->v_mount); ASSERT_VOP_LOCKED(vp, "audit_arg_vnpath"); ar = currecord();
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200509211031.j8LAVWst039557>