Date: Wed, 8 Jul 2015 03:04:58 -0700 From: Garrett Cooper <yaneurabeya@gmail.com> To: Oliver Pinter <oliver.pinter@hardenedbsd.org> Cc: "O'Connor, Daniel" <darius@dons.net.au>, Garrett Wollman <wollman@hergotha.csail.mit.edu>, freebsd-current@freebsd.org Subject: Re: gettimeofday((void *)-1, NULL) implicates core dump on recent FreeBSD 11-CURRENT Message-ID: <0F09AB91-94F3-48EB-9482-D8F729FEEA5E@gmail.com> In-Reply-To: <CAPQ4ffuuaiWGUthEhux2VrK6ZyHDT=0xd9z8k8f11N=6shdUng@mail.gmail.com> References: <CAPQ4ffuTcN_ytcH7GPY0s6OqWK9qo6MGaVZhOB%2B0ojWfd=fNCg@mail.gmail.com> <201507072241.t67MfsX5085860@hergotha.csail.mit.edu> <94BCDA65-5B86-4329-A312-4CB16E847B69@dons.net.au> <CAPQ4ffuuaiWGUthEhux2VrK6ZyHDT=0xd9z8k8f11N=6shdUng@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Jul 8, 2015, at 2:53, Oliver Pinter <oliver.pinter@hardenedbsd.org> wrote: > On 7/8/15, O'Connor, Daniel <darius@dons.net.au> wrote: >> >>> On 8 Jul 2015, at 08:11, Garrett Wollman <wollman@hergotha.csail.mit.edu> >>> wrote: >>> Perhaps the test was (erroneously) written to assume that >>> gettimeofday() was a system call, and could therefore detect invalid >>> pointers and return [EFAULT]. This has not been the case for some >>> time. (In HEAD, not since r237434, which is three years ago.) >> >> In defence of the test, the man page says it can return EFAULT. > > That's fine, but why changed the behaviour since 2015. May 27.? I have > an older FreeBSD/HardenedBSD install, where this test passing. See > some previous email in this thread. Hmm… works for me at least (no non-upstreamed changes to the kernel/userland as far as I remember — just more tests and some related build stuff). Cheers, -NGie $ uname -a FreeBSD fuji-current-amd64.local 11.0-CURRENT FreeBSD 11.0-CURRENT #1 r284769+70563d6(isilon-atf)-dirty: Thu Jul 2 13:19:45 PDT 2015 ngie@fuji-current-amd64.local:/usr/obj/usr/src/sys/FUJI amd64 $ cc -Wall -g -O0 -o busted_gettimeofday busted_gettimeofday.c $ ./busted_gettimeofday busted_gettimeofday: gettimeofday: Bad address $ cc -Wall -g -o busted_gettimeofday busted_gettimeofday.c $ ./busted_gettimeofday busted_gettimeofday: gettimeofday: Bad address $ cc -Wall -o busted_gettimeofday busted_gettimeofday.c $ ./busted_gettimeofday busted_gettimeofday: gettimeofday: Bad address [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJVnPXLAAoJEMZr5QU6S73eDswH/iasVmQLsDRQgJ/NCkKnoHGZ 2BD1hhOEP2aLz3jfrguKf8PTG+t0/g6hl3N2LFEwThkKX7lDdUjFGnbEBvj0MfJk LXUUcffq2ytDVQ8bQeD1y87Eqv8/CiCbZeZuqjqAaTkeHamy9lIO5iN+qCHv+ALp Y4IjoHK/B7Sgy9wT2HKaXs7XjhTtph1GEbTfi1UmxIhhXXtEnOkV5w+0NWSatc/I 5HbgtKhibnwzSC6NFN/eeMfFlCGIXraGocgJGZwmOP2rABYZ9vxsicgd2cfVTyXY WHSibfRcMOln8IaVYg7TwlyO2pxX73B/CglTXekHnbtrFyKUl7E/MaBuGLpwa+Y= =Uguw -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0F09AB91-94F3-48EB-9482-D8F729FEEA5E>