Date: Fri, 30 Oct 1998 09:46:49 -0800 From: Mike Smith <mike@smith.net.au> To: Paul Richards <paul@originative.co.uk> Cc: "'Luigi Rizzo'" <luigi@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/isa if_lnc.c Message-ID: <199810301746.JAA00838@dingo.cdrom.com> In-Reply-To: Your message of "Fri, 30 Oct 1998 17:38:04 GMT." <E40CBF0361C7D111914000C0F0303D108791@OCTOPUS>
next in thread | previous in thread | raw e-mail | index | archive | help
> > -----Original Message----- > > From: Luigi Rizzo [mailto:luigi@FreeBSD.ORG] > > Sent: Friday, October 30, 1998 11:54 AM > > To: cvs-committers@FreeBSD.org; cvs-all@FreeBSD.org > > Subject: cvs commit: src/sys/i386/isa if_lnc.c > > > > > > luigi 1998/10/30 03:53:58 PST > > > > Modified files: > > sys/i386/isa if_lnc.c > > Log: > > Fix a typo, and remove verbose error reporting when in > > promisc mode (they are annoying in normal mode > > as well so i am really tempted to remove them unconditionally...) > > > > Revision Changes Path > > 1.48 +4 -2 src/sys/i386/isa/if_lnc.c > > Well this is 50% ok, you're right about the spelling mistake but > disabling the error message is a bad thing. > > The error messages you've disabled signify packet corruption resulting > in the packet being dropped (CRC and Framing errors), you'd really want > to know about that sort of thing happening. This is hardly verbose error > reporting! None of the other drivers report this (the 'de'driver used to, but it was so annoying that it was disabled), and both CRC and framing errors are _very_ common on "real world" networks. > Please reverse that part of the commit. If you're seeing so many of > these errors that they're annoying you then you should find the cause, > not disable the error message. Often the cause is not fixable, or the net error rate is sufficiently low that they can be ignored. The right thing to do is to increment the input error count, and leave these messages as tunable options. -- \\ Sometimes you're ahead, \\ Mike Smith \\ sometimes you're behind. \\ mike@smith.net.au \\ The race is long, and in the \\ msmith@freebsd.org \\ end it's only with yourself. \\ msmith@cdrom.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199810301746.JAA00838>