Date: Tue, 9 Apr 2019 20:43:27 +0100 From: Chris Rees <chris@rees.space> To: rgrimes@freebsd.org, Chris Rees <crees@bayofrum.net> Cc: "O. Hartmann" <ohartmann@walstatt.org>, Chris Rees <crees@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r346017 - in head: libexec/rc libexec/rc/rc.d share/man/man5 Message-ID: <11ce03d7-8ebc-2b08-baa8-3fb31a29b3b2@rees.space> In-Reply-To: <201904091833.x39IX4pW061476@gndrsh.dnsmgr.net> References: <201904091833.x39IX4pW061476@gndrsh.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Rod, On 09/04/2019 19:33, Rodney W. Grimes wrote: >> Hey, >> >> On 9 April 2019 14:13:54 BST, "O. Hartmann" <ohartmann@walstatt.org> wrote: >>> On Sun, 7 Apr 2019 18:31:45 +0000 (UTC) >>> Chris Rees <crees@FreeBSD.org> wrote: >>> >>>> Author: crees (doc,ports committer) >>>> Date: Sun Apr 7 18:31:45 2019 >>>> New Revision: 346017 >>>> URL: https://svnweb.freebsd.org/changeset/base/346017 >>>> >>>> Log: >>>> Remove now unnecessary kldstat check before attempting to load >>> modules. >>>> Since r233109, kldload has the -n option, which silently ignores >>> options >>>> that are already loaded. >>>> >>>> >>> https://lists.freebsd.org/pipermail/freebsd-rc/2018-December/003899.html >>>> Note that this script no longer reports if the module is already >>> loaded, >>>> but it could be argued this wasn't particularly useful information. >>>> >>>> PR: docs/234248 >>>> Reviewed by: bcr (docs), kib, rgrimes (visual) >>>> Approved by: jilles >>>> Differential Revision: https://reviews.freebsd.org/D18670 >>>> >>>> Modified: >>>> head/libexec/rc/rc.d/abi >>>> head/libexec/rc/rc.d/bthidd >>>> head/libexec/rc/rc.d/cfumass >>>> head/libexec/rc/rc.d/kld >>>> head/libexec/rc/rc.d/mdconfig >>>> head/libexec/rc/rc.d/mdconfig2 >>>> head/libexec/rc/rc.d/mountcritremote >>>> head/libexec/rc/rc.d/syscons >>>> head/libexec/rc/rc.subr >>>> head/share/man/man5/rc.conf.5 >>>> >>>> Modified: head/libexec/rc/rc.d/abi >>>> >>> ============================================================================== >> >> {Snip} >> >> >>> It seems this patch breaks ZFS if ZFS is built-in kernel! >>> >>> Having ZFS as kernel built-in leaves the system not mounting ANY(!) ZFS >>> volume >>> at boot time, rendering servers unusable. >>> Mounting ZFS filesystems with "zfs mount -a" bring back the ZFS >>> filesystems as >>> expected. >>> >> Are you sure it's this causing that? Please try reverting it. > I think the trigger issue is: > grep zfs /etc/rc.d/zvol > rcvar="zfs_enable" > required_modules="zfs" > > that module requires may be going south with the > new code when the module is built into the kernel. I wondered that, but I don't think so. [crees@pegasus]~% kldstat -v |head Id Refs Address Size Name 1 30 0xffffffff80200000 11df240 kernel (/boot/kernel.PEGASUS/kernel) Contains modules: Id Name 227 newreno 215 if_lo 229 ipsec 228 mld 226 igmp 201 elf32 [crees@pegasus]~% sudo kldload ipsec kldload: can't load ipsec: module already loaded or in kernel [crees@pegasus]~% sudo kldload -n ipsec [crees@pegasus]~% echo $? 0 [crees@pegasus]~% The required_modules code calls load_kld, which uses kldload -n. This always returns true... unless Oliver has removed the zfs module from /boot/kernel perhaps? Chris -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?11ce03d7-8ebc-2b08-baa8-3fb31a29b3b2>