Date: Thu, 22 Nov 2012 22:10:35 +0800 From: Kevin Lo <kevlo@FreeBSD.org> To: David Xu <davidxu@FreeBSD.org> Cc: freebsd-current@FreeBSD.org Subject: Re: Is this a typo in if_tap.c? Message-ID: <50AE325B.1060409@FreeBSD.org> In-Reply-To: <50ADF2D4.2010805@freebsd.org> References: <50ADF2D4.2010805@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2012/11/22 17:39, David Xu wrote:
> When I was trying to create a second tap device, kernel crashed.
> Is this patch correct ?
>
>
> Index: sys/net/if_tap.c
> ===================================================================
> --- sys/net/if_tap.c (revision 243397)
> +++ sys/net/if_tap.c (working copy)
> @@ -186,7 +186,7 @@
> /* Find any existing device, or allocate new unit number. */
> i = clone_create(&tapclones, &tap_cdevsw, &unit, &dev, 0);
> if (i) {
> - dev = make_dev(&tap_cdevsw, 0, UID_ROOT, GID_WHEEL, 0600,
> + dev = make_dev(&tap_cdevsw, unit, UID_ROOT, GID_WHEEL, 0600,
> "%s%d", tapname, unit);
> }
>
The patch looks right to me.
Kevin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50AE325B.1060409>