Date: Fri, 1 Nov 2013 08:59:40 -0400 From: Ryan Steinmetz <zi@FreeBSD.org> To: Boris Samorodov <bsam@passap.ru> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r332334 - in head/finance: . vanitygen Message-ID: <20131101125940.GA8719@exodus.zi0r.com> In-Reply-To: <52738F84.8060906@passap.ru> References: <201311010112.rA11Ch1h047872@svn.freebsd.org> <52738F84.8060906@passap.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On (11/01/13 15:24), Boris Samorodov wrote:
>Hi Ryan, All,
>
>01.11.2013 05:12, Ryan Steinmetz =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
>
>> Log:
>> New port: finance/vanitygen:
>
>Thank you for working on new ports. It's always good to get a new one.
>However there are some notes inlined.
>
>> +MAINTAINER=3D ports@FreeBSD.org
>
>I'm not sure that a new unmaintained port is welcomed.
>
>> +COMMENT=3D A standalone vanity address generator for bitcoin
My bad on this, although, I had thought that portlint(1) would have caugh=
t
this.
>
>Articles should not be used at the beginning of a COMMENT.
>
>> +LIB_DEPENDS=3D pcre:${PORTSDIR}/devel/pcre
>
>A new LIB_DEPENDS syntax is preferred.
>
Do you have the announcement? After digging a bit, the only thing I was
able to find was the commit log.
>
>> +NO_STAGE=3D yes
>
>I think that new ports are supposed to support STAGE.
>
I do not believe that Tinderbox supports STAGE, so I do not have a means
of testing it at the moment.
-r
>--=20
>WBR, Boris Samorodov (bsam)
>FreeBSD Committer, http://www.FreeBSD.org The Power To Serve
--=20
Ryan Steinmetz
PGP: EF36 D45A 5CA9 28B1 A550 18CD A43C D111 7AD7 FAF2
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131101125940.GA8719>