Date: Thu, 26 May 2005 13:59:06 +0200 From: Maxime Henrion <mux@FreeBSD.org> To: Ollivier Robert <roberto@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/chkgrp chkgrp.8 chkgrp.c Message-ID: <20050526115906.GD25142@elvis.mu.org> In-Reply-To: <20050526110238.GC25142@elvis.mu.org> References: <200505261057.j4QAv4oU071149@repoman.freebsd.org> <20050526110238.GC25142@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Maxime Henrion wrote: > Ollivier Robert wrote: > > roberto 2005-05-26 10:57:04 UTC > > > > FreeBSD src repository > > > > Modified files: > > usr.sbin/chkgrp chkgrp.8 chkgrp.c > > Log: > > - Add further functionality to check for invalid characters > > - Remove keyword 'continue' for more indepth error reporting > > on each line > > - WARNS 6 Clean > > As I said to Liam some time ago, the use of strcspn() in this file is > bogus. It's not Liam's fault, he only moved this code, and didn't > introduce it. However, it would be nice to fix this since calling > strcspn(foo, " \t") has no chances of working as expected :-). Actually, I got confused... This is perfectly correct. Maxime
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050526115906.GD25142>