Date: Sat, 04 Jul 2009 09:25:59 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: neelnatu@yahoo.com Cc: freebsd-mips@freebsd.org Subject: Re: Machine Check exception during bootup Message-ID: <20090704.092559.353389034.imp@bsdimp.com> In-Reply-To: <385015.11949.qm@web34404.mail.mud.yahoo.com> References: <385015.11949.qm@web34404.mail.mud.yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <385015.11949.qm@web34404.mail.mud.yahoo.com>
Neelkanth Natu <neelnatu@yahoo.com> writes:
:
: Hi Warner,
:
: --- On Fri, 7/3/09, M. Warner Losh <imp@bsdimp.com> wrote:
:
: > From: M. Warner Losh <imp@bsdimp.com>
: > Subject: Re: Machine Check exception during bootup
: > To: neelnatu@yahoo.com
: > Cc: freebsd-mips@freebsd.org
: > Date: Friday, July 3, 2009, 8:11 PM
: > In message: <122643.47019.qm@web34403.mail.mud.yahoo.com>
: > Neelkanth Natu
: > <neelnatu@yahoo.com>
: > writes:
: > : ====
: > //depot/user/neelnatu/freebsd_sibyte/src/sys/mips/mips/genassym.c#1
: > - /u/neelnatu/p4/freebsd_sibyte/src/sys/mips/mips/genassym.c
: > ====
: > : @@ -91,6 +91,7 @@
: > : ASSYM(SIGF_UC, offsetof(struct sigframe, sf_uc));
: > : ASSYM(SIGFPE, SIGFPE);
: > : ASSYM(PGSHIFT, PGSHIFT);
: > : +ASSYM(PAGE_SHIFT, PAGE_SHIFT);
: > : ASSYM(NBPG, NBPG);
: > : ASSYM(SEGSHIFT, SEGSHIFT);
: > : ASSYM(NPTEPG, NPTEPG);
: >
: > How do PAGE_SHIFT and PGSHIFT differ?
:
: They are identical. I looked at other architectures and it seems that
: PGSHIFT is a macro defined for mips alone. The same is true for
: PGOFSET and PAGE_MASK.
:
: So I went with the obvious macro - PAGE_SHIFT.
:
: I think we should toast PGSHIFT and PGOFFSET and replace them with
: PAGE_SHIFT and PAGE_MASK respectively. What do you think?
This sounds like a good cleanup item...
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090704.092559.353389034.imp>