Date: Tue, 23 May 2023 06:23:35 -0400 From: Randall Stewart <rrs@netflix.com> To: antoine@freebsd.org Cc: Randall Stewart <rrs@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, src-committers@freebsd.org Subject: Re: git: 73ee5756dee6 - main - Fixes in the tcp infrastructure with respect to stack changes as well as other infrastructure updates for incoming rack features. Message-ID: <CALV9me339woC8N8f724NpuRKAdiJ0Gp=OUmOeG%2B8YFB1KQC%2BVw@mail.gmail.com> In-Reply-To: <CAALwa8=F0KFu-a%2BQ9L0NdQauahzrTmV%2BXqnMsXuFaDAETLtokQ@mail.gmail.com> References: <202304041231.334CVktq013660@gitrepo.freebsd.org> <CAALwa8=F0KFu-a%2BQ9L0NdQauahzrTmV%2BXqnMsXuFaDAETLtokQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] It is an interface so hidden it would be useless. Though Michael’s suggestion should work ie tcp_xxx R On Sun, May 21, 2023 at 3:01 PM Antoine Brodin <antoine@freebsd.org> wrote: > On Tue, Apr 4, 2023 at 12:31 PM Randall Stewart <rrs@freebsd.org> wrote: > > > > The branch main has been updated by rrs: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=73ee5756dee6b2110eb6fb2b2ef3cde39a1fcb4f > > > > commit 73ee5756dee6b2110eb6fb2b2ef3cde39a1fcb4f > > Author: Randall Stewart <rrs@FreeBSD.org> > > AuthorDate: 2023-04-01 05:46:38 +0000 > > Commit: Randall Stewart <rrs@FreeBSD.org> > > CommitDate: 2023-04-01 05:46:38 +0000 > > > > Fixes in the tcp infrastructure with respect to stack changes as > well as other infrastructure updates for incoming rack features. > > > > So stack switching as always been a bit of a issue. We currently use > a break before make setup which means that > > if something goes wrong you have to try to get back to a stack. This > patch among a lot of other things changes that so > > that it is a make before break. We also expand some of the function > blocks in prep for new features in rack that will allow > > more controlled pacing. We also add other abilities such as the > pathway for a stack to query a previous stack to acquire from > > it critical state information so things in flight don't get dropped > or mis-handled when switching stacks. We also add the > > concept of a timer granularity. This allows an alternate stack to > change from the old ticks granularity to microseconds and > > of course this even gives us a pathway to go to nanosecond > timekeeping if we need to (something for the data center to consider > > for sure). > > > > Once all this lands I will then update rack to begin using all these > new features. > > > > Reviewed by: tuexen > > Sponsored by: Netflix Inc > > Differential Revision: https://reviews.freebsd.org/D39210 > > Hi, > > Could you hide some stuff in netinet/tcp.h? > struct http_req breaks curl 8.1.0. > > Antoine > -- --- Randall Stewart rrs@netflix.com [-- Attachment #2 --] <div dir="auto">It is an interface so hidden it would be useless. Though Michael’s suggestion should work ie tcp_xxx</div><div dir="auto"><br></div><div dir="auto">R</div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, May 21, 2023 at 3:01 PM Antoine Brodin <<a href="mailto:antoine@freebsd.org">antoine@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Tue, Apr 4, 2023 at 12:31 PM Randall Stewart <<a href="mailto:rrs@freebsd.org" target="_blank">rrs@freebsd.org</a>> wrote:<br> ><br> > The branch main has been updated by rrs:<br> ><br> > URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=73ee5756dee6b2110eb6fb2b2ef3cde39a1fcb4f" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=73ee5756dee6b2110eb6fb2b2ef3cde39a1fcb4f</a><br>; ><br> > commit 73ee5756dee6b2110eb6fb2b2ef3cde39a1fcb4f<br> > Author: Randall Stewart <rrs@FreeBSD.org><br> > AuthorDate: 2023-04-01 05:46:38 +0000<br> > Commit: Randall Stewart <rrs@FreeBSD.org><br> > CommitDate: 2023-04-01 05:46:38 +0000<br> ><br> > Fixes in the tcp infrastructure with respect to stack changes as well as other infrastructure updates for incoming rack features.<br> ><br> > So stack switching as always been a bit of a issue. We currently use a break before make setup which means that<br> > if something goes wrong you have to try to get back to a stack. This patch among a lot of other things changes that so<br> > that it is a make before break. We also expand some of the function blocks in prep for new features in rack that will allow<br> > more controlled pacing. We also add other abilities such as the pathway for a stack to query a previous stack to acquire from<br> > it critical state information so things in flight don't get dropped or mis-handled when switching stacks. We also add the<br> > concept of a timer granularity. This allows an alternate stack to change from the old ticks granularity to microseconds and<br> > of course this even gives us a pathway to go to nanosecond timekeeping if we need to (something for the data center to consider<br> > for sure).<br> ><br> > Once all this lands I will then update rack to begin using all these new features.<br> ><br> > Reviewed by: tuexen<br> > Sponsored by: Netflix Inc<br> > Differential Revision: <a href="https://reviews.freebsd.org/D39210" rel="noreferrer" target="_blank">https://reviews.freebsd.org/D39210</a><br>; <br> Hi,<br> <br> Could you hide some stuff in netinet/tcp.h?<br> struct http_req breaks curl 8.1.0.<br> <br> Antoine<br> </blockquote></div></div><span class="gmail_signature_prefix">-- </span><br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">---<div>Randall Stewart</div><div><a href="mailto:rrs@netflix.com" target="_blank">rrs@netflix.com</a></div></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CALV9me339woC8N8f724NpuRKAdiJ0Gp=OUmOeG%2B8YFB1KQC%2BVw>