Date: Tue, 23 May 2023 06:23:35 -0400 From: Randall Stewart <rrs@netflix.com> To: antoine@freebsd.org Cc: Randall Stewart <rrs@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, src-committers@freebsd.org Subject: Re: git: 73ee5756dee6 - main - Fixes in the tcp infrastructure with respect to stack changes as well as other infrastructure updates for incoming rack features. Message-ID: <CALV9me339woC8N8f724NpuRKAdiJ0Gp=OUmOeG%2B8YFB1KQC%2BVw@mail.gmail.com> In-Reply-To: <CAALwa8=F0KFu-a%2BQ9L0NdQauahzrTmV%2BXqnMsXuFaDAETLtokQ@mail.gmail.com> References: <202304041231.334CVktq013660@gitrepo.freebsd.org> <CAALwa8=F0KFu-a%2BQ9L0NdQauahzrTmV%2BXqnMsXuFaDAETLtokQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--00000000000048f88a05fc59c8a1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable It is an interface so hidden it would be useless. Though Michael=E2=80=99s suggestion should work ie tcp_xxx R On Sun, May 21, 2023 at 3:01 PM Antoine Brodin <antoine@freebsd.org> wrote: > On Tue, Apr 4, 2023 at 12:31=E2=80=AFPM Randall Stewart <rrs@freebsd.org>= wrote: > > > > The branch main has been updated by rrs: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D73ee5756dee6b2110eb6fb2b2ef3cde= 39a1fcb4f > > > > commit 73ee5756dee6b2110eb6fb2b2ef3cde39a1fcb4f > > Author: Randall Stewart <rrs@FreeBSD.org> > > AuthorDate: 2023-04-01 05:46:38 +0000 > > Commit: Randall Stewart <rrs@FreeBSD.org> > > CommitDate: 2023-04-01 05:46:38 +0000 > > > > Fixes in the tcp infrastructure with respect to stack changes as > well as other infrastructure updates for incoming rack features. > > > > So stack switching as always been a bit of a issue. We currently us= e > a break before make setup which means that > > if something goes wrong you have to try to get back to a stack. Thi= s > patch among a lot of other things changes that so > > that it is a make before break. We also expand some of the function > blocks in prep for new features in rack that will allow > > more controlled pacing. We also add other abilities such as the > pathway for a stack to query a previous stack to acquire from > > it critical state information so things in flight don't get dropped > or mis-handled when switching stacks. We also add the > > concept of a timer granularity. This allows an alternate stack to > change from the old ticks granularity to microseconds and > > of course this even gives us a pathway to go to nanosecond > timekeeping if we need to (something for the data center to consider > > for sure). > > > > Once all this lands I will then update rack to begin using all thes= e > new features. > > > > Reviewed by: tuexen > > Sponsored by: Netflix Inc > > Differential Revision: https://reviews.freebsd.org/D39210 > > Hi, > > Could you hide some stuff in netinet/tcp.h? > struct http_req breaks curl 8.1.0. > > Antoine > --=20 --- Randall Stewart rrs@netflix.com --00000000000048f88a05fc59c8a1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"auto">It is an interface so hidden it would be useless. Though = Michael=E2=80=99s suggestion should work ie tcp_xxx</div><div dir=3D"auto">= <br></div><div dir=3D"auto">R</div><div><br><div class=3D"gmail_quote"><div= dir=3D"ltr" class=3D"gmail_attr">On Sun, May 21, 2023 at 3:01 PM Antoine B= rodin <<a href=3D"mailto:antoine@freebsd.org">antoine@freebsd.org</a>>= ; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .= 8ex;border-left:1px #ccc solid;padding-left:1ex">On Tue, Apr 4, 2023 at 12:= 31=E2=80=AFPM Randall Stewart <<a href=3D"mailto:rrs@freebsd.org" target= =3D"_blank">rrs@freebsd.org</a>> wrote:<br> ><br> > The branch main has been updated by rrs:<br> ><br> > URL: <a href=3D"https://cgit.FreeBSD.org/src/commit/?id=3D73ee5756dee6= b2110eb6fb2b2ef3cde39a1fcb4f" rel=3D"noreferrer" target=3D"_blank">https://= cgit.FreeBSD.org/src/commit/?id=3D73ee5756dee6b2110eb6fb2b2ef3cde39a1fcb4f<= /a><br> ><br> > commit 73ee5756dee6b2110eb6fb2b2ef3cde39a1fcb4f<br> > Author:=C2=A0 =C2=A0 =C2=A0Randall Stewart <rrs@FreeBSD.org><br> > AuthorDate: 2023-04-01 05:46:38 +0000<br> > Commit:=C2=A0 =C2=A0 =C2=A0Randall Stewart <rrs@FreeBSD.org><br> > CommitDate: 2023-04-01 05:46:38 +0000<br> ><br> >=C2=A0 =C2=A0 =C2=A0Fixes in the tcp infrastructure with respect to sta= ck changes as well as other infrastructure updates for incoming rack featur= es.<br> ><br> >=C2=A0 =C2=A0 =C2=A0So stack switching as always been a bit of a issue.= We currently use a break before make setup which means that<br> >=C2=A0 =C2=A0 =C2=A0if something goes wrong you have to try to get back= to a stack. This patch among a lot of other things changes that so<br> >=C2=A0 =C2=A0 =C2=A0that it is a make before break. We also expand some= of the function blocks in prep for new features in rack that will allow<br= > >=C2=A0 =C2=A0 =C2=A0more controlled pacing. We also add other abilities= such as the pathway for a stack to query a previous stack to acquire from<= br> >=C2=A0 =C2=A0 =C2=A0it critical state information so things in flight d= on't get dropped or mis-handled when switching stacks. We also add the<= br> >=C2=A0 =C2=A0 =C2=A0concept of a timer granularity. This allows an alte= rnate stack to change from the old ticks granularity to microseconds and<br= > >=C2=A0 =C2=A0 =C2=A0of course this even gives us a pathway to go to nan= osecond timekeeping if we need to (something for the data center to conside= r<br> >=C2=A0 =C2=A0 =C2=A0for sure).<br> ><br> >=C2=A0 =C2=A0 =C2=A0Once all this lands I will then update rack to begi= n using all these new features.<br> ><br> >=C2=A0 =C2=A0 =C2=A0Reviewed by: tuexen<br> >=C2=A0 =C2=A0 =C2=A0Sponsored by: Netflix Inc<br> >=C2=A0 =C2=A0 =C2=A0Differential Revision: <a href=3D"https://reviews.f= reebsd.org/D39210" rel=3D"noreferrer" target=3D"_blank">https://reviews.fre= ebsd.org/D39210</a><br> <br> Hi,<br> <br> Could you hide some stuff in netinet/tcp.h?<br> struct http_req breaks curl 8.1.0.<br> <br> Antoine<br> </blockquote></div></div><span class=3D"gmail_signature_prefix">-- </span><= br><div dir=3D"ltr" class=3D"gmail_signature" data-smartmail=3D"gmail_signa= ture"><div dir=3D"ltr">---<div>Randall Stewart</div><div><a href=3D"mailto:= rrs@netflix.com" target=3D"_blank">rrs@netflix.com</a></div></div></div> --00000000000048f88a05fc59c8a1--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CALV9me339woC8N8f724NpuRKAdiJ0Gp=OUmOeG%2B8YFB1KQC%2BVw>