Date: Sun, 20 Jul 2014 23:27:54 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Tijl Coosemans <tijl@FreeBSD.org> Cc: svn-ports-head@freebsd.org, kwm@FreeBSD.org, svn-ports-all@freebsd.org, marino@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r362304 - head/x11-toolkits/pango Message-ID: <20140720212754.GG26778@ivaldir.etoilebsd.net> In-Reply-To: <20140720165256.1f4d5d07@kalimero.tijl.coosemans.org> References: <201407200815.s6K8FG8b003096@svn.freebsd.org> <20140720132259.156d687e@kalimero.tijl.coosemans.org> <53CBA770.2010409@marino.st> <20140720113124.GD26778@ivaldir.etoilebsd.net> <20140720165256.1f4d5d07@kalimero.tijl.coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--PyMzGVE0NRonI6bs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jul 20, 2014 at 04:52:56PM +0200, Tijl Coosemans wrote: > On Sun, 20 Jul 2014 13:31:24 +0200 Baptiste Daroussin wrote: > > On Sun, Jul 20, 2014 at 01:26:40PM +0200, John Marino wrote: > >> On 7/20/2014 13:22, Tijl Coosemans wrote: > >>> On Sun, 20 Jul 2014 08:15:16 +0000 (UTC) John Marino wrote: > >>>> Author: marino > >>>> Date: Sun Jul 20 08:15:16 2014 > >>>> New Revision: 362304 > >>>> URL: http://svnweb.freebsd.org/changeset/ports/362304 > >>>> QAT: https://qat.redports.org/buildarchive/r362304/ > >>>> > >>>> Log: > >>>> x11-toolkits/pango: require explicit linking > >>>> =20 > >>>> This new configure argument will list all required libraries in the > >>>> generated pkgconf files. Before any library indirectly pulled in,= such > >>>> as libm, was not listed. > >>>> =20 > >>>> This fixes numerous regression in dports and it's more correct any= way. > >>>=20 > >>> No, this is wrong. Each port should link to the libraries it needs on > >>> its own. No port should rely on other ports to pull in libraries for > >>> them. > >>=20 > >> Then I guess we really don't need pkgconfig .pc files at all then? > >> (This is the point of .pc files, it tells how to link. libm is direct= ly > >> used by pango) > >>=20 > >> so no, it is not wrong. The generated pc file was wrong, now it's not. > >> This is why the configuration argument exists. >=20 > A .pc file normally has 1 library in the Libs field (the library the .pc > file is created for) and 0 items in the Requires field. Dependencies go > in the Libs.private or Requires.private fields. The only reason to add > dependencies to Libs or Requires is if the headers of the library expose > the API of those dependencies (e.g. the library headers define macros or > inline functions that expand to calls to functions in a dependency (such > as Gtk macros that expand to Glib function calls)). >=20 > The pango headers don't even include math.h or complex.h so they cannot > expose its API. The generated .pc file was correct, now it is wrong. >=20 > The reason the configure argument exists is probably because this is an > old .pc file from before the .private fields existed. >=20 > > The good question is "does pango exposes parts of libm or not?" if yes > > then libm should be listed in the libraries of pango.pc is not it should > > only appears in the private field. Libs.private are also there to handle the needed library when something req= uest static linking so having -lm in libs.private could make sense Otherwise I do agrree regards, Bapt --PyMzGVE0NRonI6bs Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlPMNFoACgkQ8kTtMUmk6EwOWACfccTFg+axWY5wSKHcB7INSN59 QLUAn1onrLLmwk5iBlSGyQCygLjjicri =/2mT -----END PGP SIGNATURE----- --PyMzGVE0NRonI6bs--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140720212754.GG26778>