Date: Tue, 03 Feb 2026 16:14:10 +0100 From: Olivier Certner <olce@freebsd.org> To: Dag-Erling =?UTF-8?B?U23DuHJncmF2?= <des@freebsd.org> Cc: ShengYi Hung <aokblast@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 3e6e4e4a0d42 - main - hwpstate: add CPPC support for pstate driver on AMD Message-ID: <3081716.hHqAuc6tWs@ravel> In-Reply-To: <86ms1pdgnv.fsf@ltc.des.dev> References: <6958849c.4623e.7b53a822@gitrepo.freebsd.org> <86ms1pdgnv.fsf@ltc.des.dev>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] > This doesn't work. You are reusing the same OID already used by the > Intel subdriver. The result is that whichever one happens to be first > on the linker command line works and the other one doesn't. You have to > either use a different OID for each subdriver or have both subdrivers > share a single boolean. Yes, we are aware. There's already https://reviews.freebsd.org/D54528 about that. We did not feel this was urgent, especially since I intend to retire `machdep.hwpstate_pkg_ctrl` from the AMD driver entirely (and obsolete it in the Intel driver) in favor of an easier to use interface, but this has lasted for a while now and could prevent the same knob from working in existing Intel cases. I'll move D54528 in the coming days. -- Olivier Certner [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQIzBAABCQAdFiEEmNCxHjkosai0LYIujKEwQJceJicFAmmCEMIACgkQjKEwQJce JifVdg//W4Vw/AN1ySIS2/ZfJv3ga38fmgoGMOGNoiq9cYiha+qUksXjVwxN91IZ W1NQ9FyfNqfJvI2+TmBo1Ar83jEo9+6qpH5YAuEdKl8jZS8SH22nZXJ6hqL1URuz COx5Yg7puGbq7eyjKV+4b3K2CcnXsp/9ecRXExs7zjTBCfpWpMlYMJLULIAqjhWM kaDrZkcm0Pq+GnZGFBVm8nCHdySJE2TytplrnvBc3xGWSdZpw7pQJqoRltECCrhx 56F7DCKmZ3JyFr0BvZYP0mAT1PNWcmkJzAVeM2U11zwb0/FP6Dre9scts/h/3W3Z p+p7BUE6cAuM2xoxDbl3lDYOubLReGCP04HVk0dxaIFhXmjyyvLiXwuQ2bgncTPv YzmSIjSqJKbaWAV8FsSQOw3xrNNwQMIPr8aHhvC5fYcuXra47B0sJ+L7tUjig16e qXZRMFax3YeCr3RMG04BjnJmoS/F5NG0M/wzBH1GaWZD86lOGtwtB9GrhGsdbtSj okgCDp4EqNhvA6oBDsU+fYuNuU4ejWsqlD/2/KhUGJIALno7bDGn86+KVx888iOV RgfZz9ax1ctCjbfwVRMZP9jnMAiv2FZB4SHHHh6RNtxsktj+1XQvsMS5gqNv4UeY Eg9w7NOXuGtPPI5ypZi5wS29gWQwzD+xRIfi/NejGKOmaqDcE+E= =Y7ih -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3081716.hHqAuc6tWs>