Date: Mon, 26 Dec 2016 07:43:36 +0000 From: "hrs (Hiroki Sato)" <phabric-noreply@FreeBSD.org> To: freebsd-net@freebsd.org Subject: [Differential] D8904: inet: Fix routing issue by calling if_up() Message-ID: <63e1bfb6c571f8ec4e1f0d9856cfea1c@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-ep6hmkx4cno4dfdlhp4a-req@FreeBSD.org> References: <differential-rev-PHID-DREV-ep6hmkx4cno4dfdlhp4a-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
hrs added a comment. The cause is that the prefix route was removed by in_scrubprefix() in the PRC_IFDOWN handler and never reinstalled upon PRC_IFUP because the reinstallation is done only for ifa passed to SIOCAIFADDR. Just calling if_up(ifp) looks too heavy to me because it causes extra pr_ctlinput() calls of each protocol, not only inetdomain, in order to recover the routes. What do you think about adding reinstalltion of the prefix routes in the protocol specific PRC_IFUP handler instead? REVISION DETAIL https://reviews.freebsd.org/D8904 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: sepherosa_gmail.com, delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com, adrian, bz, gnn, hiren, glebius, rwatson, karels Cc: hrs, freebsd-net-list
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?63e1bfb6c571f8ec4e1f0d9856cfea1c>